Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using indexers: specify attribute to use for the custom name #8022

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Using indexers: specify attribute to use for the custom name #8022

merged 1 commit into from
Oct 3, 2018

Conversation

pkulikov
Copy link
Contributor

@pkulikov pkulikov commented Oct 2, 2018

Main change is to fix the following line (line 31) by specifying the attribute that should be used:

To provide the indexer with a name that other languages can use, use a name attribute in the declaration. For example:

Other changes:

  • add language identifiers
  • use backticks where appropriate
  • remove mention of the DateTime property from the first paragraph as it doesn't help the topic
  • remove h3 headers from the example sections.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes @pkulikov

I've reviewed the changes, and I'll :shipit: now.

Thanks again for submitting to docs.

@BillWagner BillWagner merged commit 76b5012 into dotnet:master Oct 3, 2018
@pkulikov pkulikov deleted the patch-1 branch October 3, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants