Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the maximum open file limit section #4915

Merged
merged 2 commits into from
Apr 11, 2018
Merged

Conversation

JRAlexander
Copy link
Contributor

Updated the maximum open file limit section in MacOS .NET Core Prerequisites

Fixes #3338

Fixes #3338 macOS prerequisites: open files limit in 2.0.2+
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

I had one question, if you wanted to address it.


The default open file limit on macOS may not be sufficient for some .NET Core workloads, such as restoring projects or running unit tests.
In older .NET Core versions (before .NET Core 2.0.2), the default open file limit on macOS may not be sufficient for some .NET Core workloads, such as restoring projects or running unit tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you clarify if this is the SDK or the runtime version? (I believe SDK from the context.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great question. I believe you are correct, but I will clarify and update. Thanks, @BillWagner, your insight is always spot-on! 😄

@JRAlexander
Copy link
Contributor Author

Closing and reopening for build retrigger

@JRAlexander JRAlexander reopened this Apr 11, 2018
@mairaw mairaw removed this from the Sprint 134 (4/7/2018 - 4/27/2018) milestone Apr 11, 2018
@JRAlexander JRAlexander merged commit e71a51e into master Apr 11, 2018
@mairaw mairaw deleted the JRAlexander-patch-2 branch April 16, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS prerequisites: open files limit in 2.0.2+
3 participants