Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dotnet -i #4703

Merged
merged 2 commits into from
Mar 22, 2018
Merged

update dotnet -i #4703

merged 2 commits into from
Mar 22, 2018

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Mar 19, 2018

Fixes #4545

@danroth27 @mlorbetske please review and let me know if there's a better package for the example
I also update the version of the topic to say 2.0 since we haven't added the 2.1 options yet

@danroth27
Copy link
Member

Looks good to me, but @mlorbetske should really review this.

@mairaw
Copy link
Contributor Author

mairaw commented Mar 20, 2018

Build seemed stuck

@@ -318,6 +317,10 @@ List all templates available for MVC:

`dotnet new mvc -l`

Install version 2.0 of the Single Page Application templates for ASP.NET Core (command option available for .NET Core SDK 2.0 and later versions only):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -i option has been available with this syntax since the 1.0 CLI. I may just be reading this wrong though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're reading that right. Ok that makes other portions of this doc wrong then 😢

It seems that it was introduced in 1.1 actually.

1.0.4 options:
image

1.1 options:
image

@mairaw mairaw merged commit 9389308 into dotnet:master Mar 22, 2018
@mairaw mairaw deleted the prerelease branch March 22, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants