Correct EventPipe comparison info #42456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EventPipe docs were saying things about LTTng that were either incorrect or misleading. I think changing the comparison to use perf_events makes it more effective. - LTTng does support tracing kernel events, but as written users are likely to get the wrong idea. Perfcollect, the tool we recommend to when using LTTng with .NET, uses perf_events rather than LTTng to perform the kernel tracing. Perfcollect only uses lttng for its user-mode tracing capability. - LTTng doesn't support native callstacks as far as I am aware.
|
PTAL @brianrob @dotnet/dotnet-diag |
|
fyi @Maoni0 |
BillWagner
approved these changes
Sep 4, 2024
now.
|
I see this is already merged, but thanks for including me and thanks for fixing @noahfalk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EventPipe docs were saying things about LTTng that were either incorrect or misleading. I think changing the comparison to use perf_events makes it more effective.
Internal previews