-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated .NET Core Linux Prerequisites to remove specific versions #4099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this topic should be more similar to the other prerequisites topics where we just list the prerequisites and don't list any installation instructions for any .NET Core version. Or do we still need to list 1.x instructions and versions here? /cc @leecow
👍
docs/core/linux-prerequisites.md
Outdated
|
||
See [.NET Core 2.x Supported OS Versions](https://github.com/dotnet/core/blob/master/release-notes/2.0/2.0-supported-os.md) for the complete list of .NET Core 2.x supported operating systems, out of support OS versions, and lifecycle policy links. | ||
See [.NET Core 2.x Supported OS Versions](https://github.com/dotnet/core/blob/master/release-notes/2.0/2.0-supported-os.md) for the complete list of .NET Core 2.x supported operating systems, distibutions and versions, out of support OS versions, and lifecycle policy links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: distibutions
docs/core/linux-prerequisites.md
Outdated
@@ -458,9 +303,9 @@ To install .NET Core 2.x on Fedora 26 or Fedora 25, or .NET Core 1.x on Fedora 2 | |||
dotnet --version | |||
``` | |||
|
|||
## Install .NET Core for CentOS 7.1 (64 bit) & Oracle Linux 7.1 (64 bit) | |||
## Install .NET Core for supported CentOS and Oracle Linux distibutions\versions (64 bit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: distibutions
docs/core/linux-prerequisites.md
Outdated
|
||
To install .NET Core for CentOS 7.1 (64 bit) & Oracle Linux 7.1 (64 bit): | ||
To install .NET Core for supported CentOS and Oracle Linux distibutions\versions (64 bit): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: distibutions
@@ -194,59 +157,13 @@ Enable .NET Core 1.0 SDK and Runtime for your environment: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this step 4 looks out of place
docs/core/linux-prerequisites.md
Outdated
```bash | ||
dotnet --version | ||
``` | ||
2. To ensure you have the latest installation information, use the [.NET Core 2.x SDK and Runtime Installer instructions](https://www.microsoft.com/net/learn/get-started/linuxubuntu) for supported Ubuntu and Linux Mint distributions\versions (64 bit). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixing steps in and out of the tab makes it hard to follow. I almost thought it was a mistake to start at step 2 when I noticed you had step 1 before the tab.
docs/core/linux-prerequisites.md
Outdated
```bash | ||
scl enable rh-dotnet20 bash | ||
``` | ||
To ensure you have the latest installation information, use the [.NET Core 2.x SDK and Runtime Installer instructions](https://www.microsoft.com/net/learn/get-started/linuxredhat) for supported RHEL versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really need to say "To ensure you have the latest installation information,"?
Use -> Follow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not sure why the tabs are doing that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, by oversight...
docs/core/linux-prerequisites.md
Outdated
|
||
To install .NET Core 2.x on Fedora 26 or Fedora 25, or .NET Core 1.x on Fedora 24: | ||
To install .NET Core 2.x on supported Fedora versions, or .NET Core 1.x on Fedora 24: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To install .NET Core on supported Fedora versions?
docs/core/linux-prerequisites.md
Outdated
``` | ||
|
||
# [.NET Core 1.x](#tab/netcore1x) | ||
To install .NET Core 1.x for openSUSE (64 bit): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
step 6 below seems out of place as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. Should have put WIP on it
Also this document is the only prereqs one where people will need to leave the topic to see the specific versions. Only a small percentage of folks visiting the mac and Windows versions need to click that link. Yes, I know the info is duplicated like that, but I think this kind of info shouldn't only be in a repo md file which doesn't get localized. |
@JRAlexander - yep, makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments
docs/core/linux-prerequisites.md
Outdated
@@ -24,21 +24,22 @@ This article shows the dependencies needed to develop .NET Core applications on | |||
|
|||
# [.NET Core 2.x](#tab/netcore2x) | |||
|
|||
.NET Core 2.0 treats Linux as a single operating system. There is a single Linux build (per chip architecture) for supported Linux distros. | |||
.NET Core 2.x treats Linux as a single operating system. There is a single Linux build (per chip architecture) for supported Linux distros. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we always expand distro to distributions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Distros is an accepted term within the Linux community. Would Distributions be better for localization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked this term with the style guide team inside C+E. This is what they said:
"The CSG team is going to add a new topic that says not to use distro. It’s jargony and requires an explanation as to what it means. Probably not good for localization. And there’s also nothing wrong with distribution. For example, in that Wikipedia article, distribution is used more than 100 times. In a nutshell, distribution is more clear."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. Good to know.
docs/core/linux-prerequisites.md
Outdated
@@ -49,7 +50,7 @@ See [.NET Core 2.x Supported OS Versions](https://github.com/dotnet/core/blob/ma | |||
* Oracle Linux 7 | |||
* Fedora 24 | |||
* Debian 8.2 or later versions | |||
* Ubuntu 14.04, Ubuntu 16.04, Ubuntu 16.10\* | |||
* Ubuntu 17, 16.10\*, 16.04, 14.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need a specific release for 17 similar to what we say in the next line for 16.10?
Also shouldn't this be 17.10?
16.10 seems to have reached end of life (https://wiki.ubuntu.com/Releases). should we still list it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 17.10. 16.10 has been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope.
docs/core/linux-prerequisites.md
Outdated
```bash | ||
scl enable rh-dotnet20 bash | ||
``` | ||
To ensure you have the latest installation information, use the [.NET Core 2.x SDK and Runtime Installer instructions](https://www.microsoft.com/net/learn/get-started/linuxredhat) for supported RHEL versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/core/linux-prerequisites.md
Outdated
|
||
To install .NET Core on Debian 8 or Debian 9 (64 bit): | ||
To install .NET Core on supported Debian versions (64 bit): | ||
|
||
1. Remove any **previous preview** versions of .NET Core from your system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put the first step inside the tabs. It's easy to miss it outside.
docs/core/linux-prerequisites.md
Outdated
@@ -49,7 +50,7 @@ See [.NET Core 2.x Supported OS Versions](https://github.com/dotnet/core/blob/ma | |||
* Oracle Linux 7 | |||
* Fedora 24 | |||
* Debian 8.2 or later versions | |||
* Ubuntu 14.04, Ubuntu 16.04, Ubuntu 16.10\* | |||
* Ubuntu 17, 16.10\*, 16.04, 14.04 | |||
* Ubuntu 16.10 is supported by the latest patch release of .NET Core 1.1 | |||
* Linux Mint 17 | |||
* openSUSE 42.1 or later versions (.NET Core 1.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to your changes, but line 77-79, shouldn't the version be .x instead of .X?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup
@@ -110,50 +111,13 @@ The installer bash script is used in automation scenarios and non-admin installa | |||
> [!IMPORTANT] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for bash scripts, perhaps link to https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script for more info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that was in there at one point...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, someone put in a bare url just above... Correcting.
docs/core/linux-prerequisites.md
Outdated
@@ -20,25 +20,29 @@ This article shows the dependencies needed to develop .NET Core applications on | |||
* [Command-line with your favorite editor](tutorials/using-with-xplat-cli.md) | |||
* [Visual Studio Code](https://code.visualstudio.com/) | |||
|
|||
> [!NOTE] | |||
> The .NET Core SDK (.dotnet.sdk.x.x.x) package is not required for production servers/environments. Only the .NET Core runtime package (.dotnet.runtime.x.x.x) is needed for apps deployed to production environments. The .NET Core runtime is deployed with Standalone apps as part of the deployment, however, it must be deployed for Shared apps as a seperate deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should ".dotnet.sdk.x.x.x" be "dotnet-sdk-x.x.x" instead? Likewise for runtime.
docs/core/linux-prerequisites.md
Outdated
@@ -20,25 +20,29 @@ This article shows the dependencies needed to develop .NET Core applications on | |||
* [Command-line with your favorite editor](tutorials/using-with-xplat-cli.md) | |||
* [Visual Studio Code](https://code.visualstudio.com/) | |||
|
|||
> [!NOTE] | |||
> The .NET Core SDK (.dotnet.sdk.x.x.x) package is not required for production servers/environments. Only the .NET Core runtime package (.dotnet.runtime.x.x.x) is needed for apps deployed to production environments. The .NET Core runtime is deployed with Standalone apps as part of the deployment, however, it must be deployed for Shared apps as a seperate deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are Standalone and Shared apps? Are you talking about framework-dependent and stand-alone deployments? I think different articles should use the same terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that change had been made earlier. Not sure what happened!
docs/core/linux-prerequisites.md
Outdated
* Fedora 27, 26 | ||
* Debian 9, 8.7 or later versions | ||
* Ubuntu 17.10, 16.04, 14.04 | ||
* Linux Mint 18,17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: missing space after comma.
docs/core/linux-prerequisites.md
Outdated
4. Run the `dotnet --version` command to prove the installation succeeded. | ||
|
||
```bash | ||
dotnet --version | ||
``` | ||
|
||
For Red Hat .NET channel access registration help, see [Chapter 1 of the .NET Core 1.1 Getting Started Guide](https://access.redhat.com/documentation/en/net-core/1.1/paged/getting-started-guide/) at Red Hat. | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the previous line render as heading on GitHub. I think you need an empty line above it if you want <hr>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the syntax for the tabs, but I agree with you that it probably needs an empty line above it @svick. Right now the layout is broken here.
docs/core/linux-prerequisites.md
Outdated
## Install .NET Core for Ubuntu 14.04, Ubuntu 16.04, Ubuntu 16.10 & Linux Mint 17, Linux Mint 18 (64 bit) | ||
|
||
1. Remove any **previous preview** versions of .NET Core from your system. | ||
## Install .NET Core for supported Ubuntu and Linux Mint distributions\versions (64 bit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think this should use the normal forward slash, not backslash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch!
docs/core/linux-prerequisites.md
Outdated
## Install .NET Core for CentOS 7.1 (64 bit) & Oracle Linux 7.1 (64 bit) | ||
|
||
To install .NET Core for CentOS 7.1 (64 bit) & Oracle Linux 7.1 (64 bit): | ||
## Install .NET Core for supported CentOS and Oracle Linux distributions\versions (64 bit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: forward slash instead of backslash here too (and on the line below).
What's the status of this PR @JRAlexander? Is this ready for a new review or is this WIP? |
It should be ready for a new review, IIRC.
|
89ead2b
to
39402d3
Compare
* Oracle Linux 7 | ||
* Fedora 27, 26 | ||
* Debian 9, 8.7 or later versions | ||
* Ubuntu 17.10, 16.04, 14.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu 18.04 will be released this month. We may as well add it to the list now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronfranke, as soon as Ubuntu 18.04 is supported, we'll be sure to add it. Thanks!
This PR has several commits and some of them are minor fixups like formatting. Consider rebasing the commits. |
@aaronfranke this PR is also affected by the work for #4789 🚧 We're working on it. |
Closing and reopening after build failure to retrigger build. |
Closing and reopening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left a couple of comments...
docs/core/linux-prerequisites.md
Outdated
@@ -20,25 +20,28 @@ This article shows the dependencies needed to develop .NET Core applications on | |||
* [Command-line with your favorite editor](tutorials/using-with-xplat-cli.md) | |||
* [Visual Studio Code](https://code.visualstudio.com/) | |||
|
|||
> [!NOTE] | |||
> The .NET Core SDK (.dotnet-sdk-x-x64.x.x.x) package is not required for production servers/environments. Only the .NET Core runtime package (.dotnet-x-x64.x.x.x) is needed for apps deployed to production environments. The .NET Core runtime is deployed with apps as part of a self-contained deployment, however, it must be deployed for Framework-dependent deployed apps seperately. For general information about Framework-dependent and Self-contained deployment types, please see [.NET Core application deployment](https://docs.microsoft.com/en-us/dotnet/core/deploying/). Also see [Self-contained Linux applications](https://github.com/dotnet/core/blob/master/Documentation/self-contained-linux-apps.md) for specific guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: seperately
lower case Framework and Self in the text (not in the article titles)
For last sentence: boilerplate sentence for more info is "For more information, see ..." or "For more information about X, see..." . And avoid please in general.
I find the file names confusing here, Also, is the runtime called a package?
Link inside docs should be relative. Also wondering if we need to port the second article over (with a new issue) so it also gets localized and part of the official docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the filenames. Yes, it's a package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put a note on my board to port over the other doc. :)
docs/core/linux-prerequisites.md
Outdated
```bash | ||
sudo sh -c 'echo -e "[packages-microsoft-com-prod]\nname=packages-microsoft-com-prod \nbaseurl=https://packages.microsoft.com/yumrepos/microsoft-rhel7.3-prod\nenabled=1\ngpgcheck=1\ngpgkey=https://packages.microsoft.com/keys/microsoft.asc" > /etc/zypp/repos.d/dotnetdev.repo' | ||
``` | ||
2. Install .NET Core 2.x on supported supported SUSE Linux Enterprise Server and OpenSUSE distributions/versions (64 bit): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supported supported
docs/core/linux-prerequisites.md
Outdated
@@ -103,537 +105,288 @@ On Linux, there are two installer package choices: | |||
|
|||
### Scripting Installs with the .NET Core installer script | |||
|
|||
The `dotnet-install` scripts are used to perform a non-admin install of the CLI toolchain and the shared runtime. You can download the script from: https://dot.net/v1/dotnet-install.sh | |||
The [`dotnet-install` scripts](./tools/dotnet-install-script.md) are used to perform a non-admin install of the CLI toolchain and the shared runtime. You can download the script from [https://dot.net/v1/dotnet-install.sh](https://dot.net/v1/dotnet-install.sh). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/core/linux-prerequisites.md
Outdated
@@ -103,537 +105,288 @@ On Linux, there are two installer package choices: | |||
|
|||
### Scripting Installs with the .NET Core installer script | |||
|
|||
The `dotnet-install` scripts are used to perform a non-admin install of the CLI toolchain and the shared runtime. You can download the script from: https://dot.net/v1/dotnet-install.sh | |||
The [`dotnet-install` scripts](./tools/dotnet-install-script.md) are used to perform a non-admin install of the CLI toolchain and the shared runtime. You can download the script from [https://dot.net/v1/dotnet-install.sh](https://dot.net/v1/dotnet-install.sh). | |||
|
|||
The installer bash script is used in automation scenarios and non-admin installations. This script also reads PowerShell switches, so they can be used with the script on Linux/OS X systems. | |||
|
|||
> [!IMPORTANT] | |||
> Before running the script, install the required [dependencies](https://github.com/dotnet/core/blob/master/Documentation/prereqs.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this just links back to this topic. maybe link to the #linux-distribution-dependencies section?
docs/core/linux-prerequisites.md
Outdated
```bash | ||
dotnet --version | ||
``` | ||
* [.NET Core Runtime 1.1.7 install link](https://www.microsoft.com/net/download/thank-you/dotnet-runtime-1.1.7-linux-debian-x64-binaries) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this follow the same pattern as the other sections and be on a table (even though there is only one column)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and forth with this. It fills the entire page with both columns on the sides and looks really strange.
``` | ||
| Runtimes / SDKs |Ubuntu 16.04 / Linux Mint 18|Ubuntu 14.04 / Linux Mint 17| | ||
|-------------------------|----------------------------|----------------------------| | ||
|.NET Core Runtime 1.1.7 |[Install link](https://www.microsoft.com/net/download/thank-you/dotnet-runtime-1.1.7-linux-ubuntu-16.04-x64-binaries) |[Install link](https://www.microsoft.com/net/download/thank-you/dotnet-runtime-1.1.7-linux-ubuntu-14.04-x64-binaries) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rowanmiller are there any query params that we can use in these links for you to track that these downloads are coming from docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required for links like this. We get referral information by default, so we know which traffic is coming from docs (and what page it comes from).
docs/core/linux-prerequisites.md
Outdated
|
||
4. Extract the .NET Core SDK binaries. | ||
>[!IMPORTANT] | ||
> To use .NET Core 2.1 with Visual Studio, you'll need to [install Visual Studio 2017 15.7 Preview 1 or newer](https://www.visualstudio.com/vs/preview/?dotnetid=169771757.1498243949). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove future tense and do you need that dotnetid there? should you mention when to expect support for VS for Mac (see https://blogs.msdn.microsoft.com/dotnet/2018/04/11/announcing-net-core-2-1-preview-2/)?
@TerryGLee is there any special campaign link for the preview version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mairaw I'll inquire, and include you on the thread.
docs/core/linux-prerequisites.md
Outdated
```bash | ||
scl enable rh-dotnet20 bash | ||
``` | ||
To ensure you have the latest installation information, follow the [.NET Core 2.x SDK and Runtime Installer instructions](https://www.microsoft.com/net/learn/get-started/linuxredhat) for supported RHEL versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should probably point to just the install instructions right, and not the Get Started tutorial? https://www.microsoft.com/net/download/linux-package-manager/rhel/sdk-current
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know for most content on this page you want a specific version, but if you have places where you just want current, then you can replace the version number in the URL with current
(like the above link)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that should have been pointing to the install instructions. Great catch! Thanks, @rowanmiller!
closing and reopening |
9d4cfee
to
46b0450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @JRAlexander. I'm approving it now since it's close to being done but I still found some minor issues to be fixed. Thanks!
docs/core/linux-prerequisites.md
Outdated
@@ -20,25 +20,28 @@ This article shows the dependencies needed to develop .NET Core applications on | |||
* [Command-line with your favorite editor](tutorials/using-with-xplat-cli.md) | |||
* [Visual Studio Code](https://code.visualstudio.com/) | |||
|
|||
> [!NOTE] | |||
> The .NET Core SDK package is not required for production servers/environments. Only the .NET Core runtime package is needed for apps deployed to production environments. The .NET Core runtime is deployed with apps as part of a self-contained deployment, however, it must be deployed for Framework-dependent deployed apps seperately. For more information about framework-dependent and self-contained deployment types, see [.NET Core application deployment](https://docs.microsoft.com/en-us/dotnet/core/deploying/). Also see [Self-contained Linux applications](https://github.com/dotnet/core/blob/master/Documentation/self-contained-linux-apps.md) for specific guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relative link to the deployment topic: [./deploying/index.md]
typo: seperately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
docs/core/linux-prerequisites.md
Outdated
|
||
5. Add dotnet to your PATH | ||
>[!IMPORTANT] | ||
> To use .NET Core 2.1 with Visual Studio, you need to [install Visual Studio 2017 15.7 Preview 1 or newer](https://www.visualstudio.com/vs/?utm_medium=microsoft&utm_source=docs.microsoft.com&utm_campaign=banner+cta&utm_content=vs2017). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case, the non-campaign link was better: https://www.visualstudio.com/vs/preview/
docs/core/linux-prerequisites.md
Outdated
> | ||
> If you have problems with the .NET Core 1.x installation on a supported Linux distribution/version, consult the [1.0.0 Known Issues](https://github.com/dotnet/core/blob/master/release-notes/1.0/1.0.0-known-issues.md) and [1.0.1 Known Issues](https://github.com/dotnet/core/blob/master/release-notes/1.0/1.0.1-known-issues.md) topics for your installed distributions/versions. | ||
> If you have problems with the .NET Core 1.x installation on a supported Linux distribution/version, consult the following topics for your installed distributions/versions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: not sure if you need to say this again. Maybe a list with all known issues in sequence?
@mairaw, as always, very thoughtful and great feeedback! Thank you!!! |
Updated .NET Core Linux Prerequisites to remove specific versions
Summary
Updated .NET Core Linux Prerequisites to remove specific versions of Linux distributions and link to their respective download instruction pages.
Internal Review URL
Fixes #4086