Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WCF assemblies #3208

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Update WCF assemblies #3208

merged 1 commit into from
Sep 25, 2017

Conversation

TianqiZhang
Copy link
Contributor

@TianqiZhang TianqiZhang commented Sep 22, 2017

@mairaw
Copy link
Contributor

mairaw commented Sep 25, 2017

@TianqiZhang any clue why the namespace system.servicemodel is not found for .NET Core 2.0, when the APIs underneath exist in 2.0?

see here an example: https://review.docs.microsoft.com/en-us/dotnet/api/system.servicemodel?view=netcore-2.0&branch=pr-en-us-3208

@mairaw
Copy link
Contributor

mairaw commented Sep 25, 2017

@zhenlan do you wanna take a look at this PR and see if you see the APIs you'd expect to be added here? I already found an issue with the namespace page for System.ServiceModel.

@TianqiZhang
Copy link
Contributor Author

@mairaw just checked, it should be an incremental build issue, this namespace has no content change, only moniker change, so it did not re-build for the PR. If we merge this PR and do a force build, the monikers on page will be fixed.

@mairaw
Copy link
Contributor

mairaw commented Sep 25, 2017

Cool. I'll merge and test on master then. Thanks @TianqiZhang!

@mairaw mairaw merged commit f3e049b into master Sep 25, 2017
@mairaw mairaw deleted the mdoc-5.0.0.19 branch September 25, 2017 18:15
@zhenlan
Copy link
Member

zhenlan commented Sep 26, 2017

Looks good. Thank you @mairaw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants