Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified remarks on setting InnerHandler #3007

Merged
merged 2 commits into from
Aug 29, 2017
Merged

Clarified remarks on setting InnerHandler #3007

merged 2 commits into from
Aug 29, 2017

Conversation

alfredmyers
Copy link
Contributor

No description provided.

@dnfclas
Copy link

dnfclas commented Aug 27, 2017

@alfredmyers,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

rpetrusha
rpetrusha suggested changes Aug 28, 2017
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment •
edited by mairaw
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enormously improving the clarity of the remarks, @alfredmyers! Would you mind making the suggested corrections as well, so that these appear as links rather than plain text? If you'd like us to make the corrections, please let us know.

xml/System.Net.Http/DelegatingHandler.xml Outdated
@@ -23,9 +23,9 @@
<format type="text/markdown"><![CDATA[

## Remarks
This application normally instantiate this class and then set the inner handler or provide an inner handler in the constructor.
An application should provide an inner handler either in the constructor or through the InnerHandler property before calling SendAsync() otherwise an InvalidOperationException will be thrown.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InnerHandler property --> <xref:System.Net.Http.DelegatingHandler.InnerHandler> property
SendAsync() otherwise an InvalidOperationException -->
<xref:System.Net.Http.DelegatingHandler.SendAsync%2A>; otherwise, an <xref:System.InvalidOperationException>

The ` tags shouldn't be fenced in the text; I've fenced them only so markdown renders the tags.

@rpetrusha
Copy link
Contributor

Thanks for making the additional changes, @alfredmyers. We'll merge as soon as the build completes.

@mairaw
Copy link
Contributor

mairaw commented Aug 29, 2017

Build finished but status wasn't updated. Trying again.

@mairaw mairaw closed this Aug 29, 2017
@mairaw mairaw reopened this Aug 29, 2017
@dnfclas
Copy link

dnfclas commented Aug 29, 2017

@alfredmyers,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@mairaw mairaw merged commit 0194619 into dotnet:master Aug 29, 2017
@alfredmyers alfredmyers deleted the patch-3 branch August 29, 2017 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpetrusha rpetrusha rpetrusha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alfredmyers @dnfclas @rpetrusha @mairaw