Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing mistakes #2936

Merged
merged 1 commit into from
Aug 17, 2017
Merged

fixing mistakes #2936

merged 1 commit into from
Aug 17, 2017

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Aug 17, 2017

While reviewing some of the CLI topics today, I've realized that working late on a Sunday night clouds your vision and makes your brain not work properly. 😄

Fixing some mistakes for the new dotnet help command.

Copy link
Contributor

@JRAlexander JRAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only one small item.

List the project references for the project in the current directory:

`dotnet list reference`
`dotnet help new`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this example be wrapped in a console code sample markup to be consistent?

Copy link
Contributor Author

@mairaw mairaw Aug 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, all of our CLI examples are inline code. So to be consistent, I'd have to change all others. We currently don't have a language identifier for .NET Core CLI. I can make a test on a separate branch to see which one looks better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understand. LGTM then.

Copy link
Contributor

@JRAlexander JRAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairaw mairaw merged commit ca7c886 into master Aug 17, 2017
@mairaw mairaw deleted the mairaw-patch-5 branch August 17, 2017 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants