-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.net guide new name #2628
.net guide new name #2628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roslyn can't be renamed, since it's the technology's official name. Otherwise, LGTM.
docs/toc.md
Outdated
@@ -223,7 +223,7 @@ | |||
### [Documenting your code](csharp/codedoc.md) | |||
### [Versioning](csharp/versioning.md) | |||
<!-- End of C# Concepts section --> | |||
<!--## [🔧 Using the .NET Compiler Platform](csharp/roslyn/index.md)--> | |||
<!--## [🔧 Using the .NET Compiler](csharp/roslyn/index.md)--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Roslyn; the official name of the technology is ".NET Compiler Platform".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistent word use will always be beyond our reach 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @tdykstra. This is ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @tdykstra! Need to wait a couple of builds to finish.
No description provided.