Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.net guide new name #2628

Merged
merged 2 commits into from
Jul 14, 2017
Merged

.net guide new name #2628

merged 2 commits into from
Jul 14, 2017

Conversation

tdykstra
Copy link
Contributor

No description provided.

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roslyn can't be renamed, since it's the technology's official name. Otherwise, LGTM.

docs/toc.md Outdated
@@ -223,7 +223,7 @@
### [Documenting your code](csharp/codedoc.md)
### [Versioning](csharp/versioning.md)
<!-- End of C# Concepts section -->
<!--## [🔧 Using the .NET Compiler Platform](csharp/roslyn/index.md)-->
<!--## [🔧 Using the .NET Compiler](csharp/roslyn/index.md)-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Roslyn; the official name of the technology is ".NET Compiler Platform".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent word use will always be beyond our reach 😢

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @tdykstra. This is ready to merge.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @tdykstra! Need to wait a couple of builds to finish.

@mairaw mairaw merged commit c3c9c12 into master Jul 14, 2017
@mairaw mairaw deleted the td-dotnet-guide branch July 14, 2017 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants