Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document nullable reference type annotations breaking change #22861

Merged
merged 3 commits into from
Feb 17, 2021

Conversation

scottaddie
Copy link
Member

@scottaddie scottaddie commented Feb 17, 2021

Document the breaking change described at aspnet/Announcements#444

Internal review page

@scottaddie
Copy link
Member Author

@gewarren Ready for review.

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@scottaddie scottaddie merged commit 99dc044 into master Feb 17, 2021
@scottaddie scottaddie deleted the scottaddie/nullable-ref-type branch February 17, 2021 14:15
@gewarren
Copy link
Contributor

@scottaddie Here's the corresponding article for core .NET libraries: https://docs.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/nullable-ref-type-annotation-changes. I added info about the actual change to each API, if you want to consider adding that. We should probably also link between these articles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants