Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add f1-keyword for class used as generic type constraint #21037

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Add f1-keyword for class used as generic type constraint #21037

merged 2 commits into from
Oct 13, 2020

Conversation

TheSench
Copy link
Contributor

@TheSench TheSench commented Oct 12, 2020 •
edited
Loading

Summary

This PR adds an f1_keyword for the generic where clause context of the class keyword. This allows the F1 help to route to this usage of the keyword, rather than always routing to the class declaration page.

Fixes part of #20799, Roslyn changes under dotnet/roslyn#48506.

Alternative Solution

This PR is unnecessary if the existing whereconstraint_CSharpKeyword keyword can be used by Roslyn for this context.

@dotnet-bot dotnet-bot added this to the October 2020 milestone Oct 12, 2020
@BillWagner
Copy link
Member

@TheSench This change looks good to me.

is there are related roslyn PR to reference? /cc @davidwengier

@TheSench
Copy link
Contributor Author

@TheSench This change looks good to me.

is there are related roslyn PR to reference? /cc @davidwengier

Yes, it should be linked in the initial comment, but here it is for reference:
dotnet/roslyn#48506

@TheSench TheSench mentioned this pull request Oct 12, 2020
Merged
@TheSench
Copy link
Contributor Author

I've started discussion on the necessity of this change versus using the existing whereconstraint_CSharpKeyword. I think this change may still be needed (and if so, an additional one for struct must be added).

@TheSench
Copy link
Contributor Author

I've started discussion on the necessity of this change versus using the existing whereconstraint_CSharpKeyword. I think this change may still be needed (and if so, an additional one for struct must be added).

Since this PR is either completely unnecessary, or new keywords are needed for both class and struct, I've gone ahead and added structcontraint to this PR.

@BillWagner
Copy link
Member

Thanks @TheSench

This LGTM as well. I'll :shipit: now.

@BillWagner BillWagner merged commit 6eaccee into dotnet:master Oct 13, 2020
BillWagner added a commit that referenced this pull request Oct 14, 2020
@cxwtool @gewarren
@TheSench @Youssef1313 @IEvangelist @BillWagner @willwhitwellbailey @LakshanF @kapsiR @tdykstra @icyfire0573
Merge master into live (#21095)
39b1d5f 
* Respond to feedback for deserialization constructors (#21051)

* Fixes #20949. (#21052)

* Add f1-keyword for `class` used as generic type constraint (#21037)

* Add f1-keyword for `class` used as generic type constraint

* Add structconstraint

* Update CS0267 message and simplify example (#21047)

* Update CS0267 message and simplify example

* Update ms.date

* Added a link (#21058)

* Fixes #20958. (#21054)

* fix the source path for retired C# 7.x content (#21059)

The "whats-new" folder was missing.

* Removing redundant pipe character (#20931)

* Update single-file.md (#20925)

update ReadyToRun link now that we have the docs for it.

* Remove statement about TLS 1.3 for .NET Core 3.0 (#20922)

I think, TLS 1.3 won't be supported by .NET Core 3.0 since it's out of support and the implementation is coming with .NET 5, as stated in [Transport Layer Security (TLS) best practices with the .NET Framework](#4675 (comment)).

This info should be removed, so we have no misleading information out there... 😉

* SslStream/NegotiateStream breaking change (#20979)

* Add workload and app model to glossary (#21046)

Co-authored-by: Genevieve Warren <[email protected]>

* Breaking change for key-value pair serialization (#21050)

* Update .NET Standard overview for .NET 5 (#20955)

Co-authored-by: Genevieve Warren <[email protected]>

* Update get-started-vscode.md (#21072)

http to https after verifying link

Co-authored-by: Genevieve Warren <[email protected]>
Co-authored-by: Jon Senchyna <[email protected]>
Co-authored-by: Youssef Victor <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: Bill Wagner <[email protected]>
Co-authored-by: William Whitwell Bailey <[email protected]>
Co-authored-by: Lakshan Fernando <[email protected]>
Co-authored-by: kapsiR <[email protected]>
Co-authored-by: Tom Dykstra <[email protected]>
Co-authored-by: icyfire0573 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

@BillWagner BillWagner Awaiting requested review from BillWagner

Assignees
No one assigned
Labels
dotnet-csharp/svc lang-reference/subsvc
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@TheSench @BillWagner @davidwengier @dotnet-bot