Removing outdated VS references (Part 3) #1811

guardrex · 2017-03-28T01:27:09Z

Addresses #1795: This is Part 3 of the updates, so let's call it 🦈 Oh Hell No! 🦈

Removes and hardens references for VS2013 and VS2015.
Updates a handful of links

dnfclas · 2017-03-28T01:27:13Z

@guardrex,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

mairaw

Thanks @guardrex. I need to stop the review now so just sending the comments I have up until this point. Some of the .NET Core articles should not be part of this sweep because they're larger updates for the csproj project. I'll comment on that later.

mairaw · 2017-03-29T01:46:32Z

.openpublishing.redirection.json

@@ -294,6 +294,10 @@
        "redirect_url": "/visualstudio/ide/visual-studio-ide"
    },
    {
+        "source_path": "docs/visual-basic/getting-started/breaking-changes-in-visual-studio-2015.md", 


not so sure about this one. I think we should keep the topic but remove version from the file name and make the topic cumulative over time. I'll redirect all the C# and VB topics from VS.140 (Vs 2015) version to here soon.

@mairaw Since we removed the 2013 version in the csharp docs and the 2015 version is currently in the VB area (and has VB is in the title), I'll await your instructions on where you want this.

mairaw · 2017-03-29T01:53:55Z

docs/core/docker/visual-studio-tools-for-docker.md

@@ -19,8 +19,8 @@ Developing and debugging your application in a Docker container can be a ceremon
 >The current version targets Linux Docker containers, with Windows Containers coming soon.

 ## Prerequisites
- [Microsoft Visual Studio 2015 Update 3](https://www.visualstudio.com/downloads/download-visual-studio-vs)
- [.NET Core 1.0.1 - VS 2015 Tooling Preview 2](https://go.microsoft.com/fwlink/?LinkID=827546)
+- [Microsoft Visual Studio 2017](https://www.visualstudio.com/)


@spboyer @BillWagner wondering if this topic needs to be rewritten further. Docker support is now enabled as part of the workloads and not as a separate extension, correct?

Yes, Docker tools are installed with Visual Studio 2017, if you install the ASP.NET Workload.

So @guardrex, these instructions need to be reviewed. You no longer download the tool, you get it with the workloads (I believe it comes with the .NET Core workload too, need to check)

rpetrusha · 2017-04-11T16:37:04Z

docs/csharp/language-reference/language-specification.md

@@ -33,8 +33,6 @@ translation.priority.ht:
 ---
 # C# Language Specification
 The C# Language Specification is the definitive source for C# syntax and usage. This specification contains detailed information about all aspects of the language, including many points that the documentation for Visual C# doesn't cover.  
-
-You can download version 5.0 of this specification from the [Microsoft Download Center](http://www.microsoft.com/download/details.aspx?id=7029). If you've installed Visual Studio 2015, you can also find the specification on your computer in the Program Files (x86)/Microsoft Visual Studio 14.0/VC#/Specifications/1033 folder. If you have another version of Visual Studio installed or if you installed Visual Studio in a language other than English, change the path as appropriate.

 Version 6.0 of the specification is not currently available, but an unofficial draft exists in [the dotnet/csharplang GitHub repository](https://github.com/dotnet/csharplang/blob/master/spec/README.md).


In this case, I think that we want to provide the link tot he unofficial draft, but we also want to provide a link/information about the last official version of the C# specification.

guardrex · 2017-04-11T18:46:30Z

@rpetrusha I reverted the removal of that section and fixed a merge conflict.

BillWagner · 2017-04-17T20:21:28Z

docs/csharp/programming-guide/interop/walkthrough-office-programming.md

 You must have Microsoft Office Excel and Microsoft Office Word installed on your computer to complete this walkthrough.  
+=======
+ You must have Microsoft Office Excel 2007 or later and Microsoft Office Word 2007 or later installed on your computer to complete this walkthrough.  
+>>>>>>> Updates



This merge conflict needs to be resolved.

@BillWagner I'll take care of that.

Also, @mairaw floated the idea of keeping the breaking changes topic.

I think we should keep the topic but remove version from the file name and make the topic cumulative over time. I'll redirect all the C# and VB topics from VS.140 (Vs 2015) version to here soon.

Since we removed the 2013 version in the csharp docs and the 2015 version is currently in the VB area (and has VB is in the title), I need guidance on what should be done with the breaking changes topic.

The 2013 topic will still exist in msdn. If we remove the 2015 topic, it's gone forever, So unless we don't want to have the topic, we should keep it.

@mairaw This PR thus far keeps it, but it renames it from ...

docs/visual-basic/getting-started/breaking-changes-in-visual-studio-2015.md

to

docs/visual-basic/getting-started/breaking-changes-in-visual-studio.md

What we'd be missing is a similar doc ...

docs/csharp/getting-started/breaking-changes-in-visual-studio.md

... over in the csharp area.

At least today, this doesn't seem to provide any useful content. There are no "breaking changes" to show AFAICT from its current content. Should they be kept around in case in the future there are language-related VS breaking changes to report?

Four options:

Keep the doc but also keep the 2015 name on it

Keep the doc and rename it as done in the PR to remove the year

Keep the doc (either 1 or 2 above) and mirror it over in the csharp area

Kill this doc off 🔫

if the topic is not useful, just kill it!

guardrex · 2017-04-17T23:51:40Z

@BillWagner @mairaw We have a breaking changes doc in the VB Getting Started area. It doesn't do much more than point the reader to the VS 2017 docs. We had a similar one for VS 2013 in the csharp area that we removed. It had similar content to this one.

How do you want to proceed with this one? Would you like me to reconstitute the one we removed in the csharp area?

mairaw

Left a few comments.

mairaw · 2017-04-27T07:10:03Z

docs/core/docker/visual-studio-tools-for-docker.md

@@ -19,8 +19,8 @@ Developing and debugging your application in a Docker container can be a ceremon
 >The current version targets Linux Docker containers, with Windows Containers coming soon.

 ## Prerequisites
- [Microsoft Visual Studio 2015 Update 3](https://www.visualstudio.com/downloads/download-visual-studio-vs)
- [.NET Core 1.0.1 - VS 2015 Tooling Preview 2](https://go.microsoft.com/fwlink/?LinkID=827546)
+- [Microsoft Visual Studio 2017](https://www.visualstudio.com/)


So @guardrex, these instructions need to be reviewed. You no longer download the tool, you get it with the workloads (I believe it comes with the .NET Core workload too, need to check)

mairaw · 2017-04-27T07:12:38Z

docs/core/porting/libraries.md

@@ -13,23 +13,23 @@ ms.assetid: a0fd860d-d6b6-4659-b325-8a6e6f5fa4a1

 # Porting to .NET Core - Libraries

-With the release of .NET Core 1.0, there is an opportunity to port existing library code so that it can run cross-platform.  This article discusses the .NET Standard Library, unavailable technologies, how to account for the smaller number of APIs available on .NET Core 1.0, how to use the tooling that ships with .NET Core SDK Preview 2, and recommended approaches to porting your code.
+With the release of .NET Core 1.0, there is an opportunity to port existing library code so that it can run cross-platform. This article discusses the .NET Standard Library, unavailable technologies, how to account for the smaller number of APIs available on .NET Core 1.0, how to use the tooling that ships with .NET Core SDK Preview 2, and recommended approaches to porting your code.


this topic needed a more extensive revision. Just updating the version was not enough here but @cartermp already has a PR here: #1792. But since you've cleaned the topic a bit of extra spaces, I'm willing to leave this one here.

mairaw · 2017-04-27T07:14:56Z

docs/core/tools/using-ci-with-cli.md

@@ -78,12 +78,12 @@ for more information.

 ### AppVeyor

-The [appveyor.com ci](https://www.appveyor.com/) has .NET Core SDK preview2 already installed in the build worker image `Visual Studio 2015`.
+The [appveyor.com ci](https://www.appveyor.com/) has .NET Core SDK 1.0.1 already installed in the build worker image `Visual Studio 2017`.


this one is another one that needs a more extensive revision and is covered here: #1556

guardrex · 2017-04-27T21:57:45Z

@mairaw I took a stab 🔪 at the Docker language. Not being a Docker pro, I'd like feedback there. I think ur saying on the other two to let the revisions go in on those other two PR's to get them fixed up; I didn't make changes for those here. It's ready for another look. 👀

BillWagner

@guardrex I reviewed the Docker changes and had one change.

/cc @mairaw

BillWagner · 2017-04-27T22:01:48Z

docs/core/docker/visual-studio-tools-for-docker.md


-> [!NOTE]
->The current version targets Linux Docker containers, with Windows Containers coming soon.
+[Microsoft Visual Studio 2017](https://www.visualstudio.com/) supports building and debugging .NET Framework web/console applications using Windows containers or .NET Core web/console applications using Linux containers. The [Docker for Windows](https://docs.docker.com/docker-for-windows/install/) install package includes everything you need to run Docker on a Windows system.


We now support Windows containers, in addition to Linux containers.

The docker tools are installed as part of the .NET Core workload with the Visual Studio 2017 installer. The link isn't needed.

guardrex · 2017-04-27T22:21:46Z

@BillWagner Revised. I suppose since this topic explicitly pertains to .NET Core apps (the instructions have the reader create such an app), we don't need to mention other workloads that may include the Docker support when installing VS. If not, I'll need to find out which other workloads install Docker support and mention them.

BillWagner · 2017-04-27T22:23:44Z

@guardrex The only workload I saw Docker tools listed in was .NET Core. I did look before I commented.

guardrex · 2017-04-27T22:24:31Z

Ah ... fair enough. Cool.

guardrex · 2017-04-27T22:27:27Z

Looks like they should update this: https://github.com/Microsoft/DockerTools ... I'll note it to them.

guardrex · 2017-04-27T23:07:34Z

@BillWagner See Devin's remark at microsoft/DockerTools#10 ... Docker for Windows ... https://docs.docker.com/docker-for-windows/install ... I'm planning on adding that back. Is that the correct move?

mairaw · 2017-04-27T23:18:20Z

Yep, our comments were about the VS tooling that is no longer a separate download.

guardrex · 2017-04-27T23:20:02Z

This was the one that threw me a bit: #1811 (comment)

No probs. I'll revert that back (i.e., add the Docker for Windows link back)

guardrex · 2017-04-27T23:37:43Z

Let's see if this language works. Since VS prob can't debug without the runtime, I combine them to say what the reader can do with both installed.

BillWagner · 2017-04-28T00:15:11Z

I just read the Docker install notes, and that's accurate.

mairaw · 2017-05-01T17:51:22Z

Ok to merge this now @BillWagner?

guardrex added Area - C# Guide labels Mar 28, 2017

guardrex added this to the April 2017 milestone Mar 28, 2017

guardrex self-assigned this Mar 28, 2017

dnfclas added the cla-already-signed label Mar 28, 2017

mairaw reviewed Mar 29, 2017

View reviewed changes

guardrex removed this from the April 2017 milestone Mar 29, 2017

rpetrusha reviewed Apr 11, 2017

View reviewed changes

Luke Latham and others added 5 commits April 13, 2017 16:28

Initial commit

8d425e0

Updates

beb1400

Updates

cf3e02f

Updates

e775b0a

Revert removal of last official release spec

4e6529c

guardrex added the WIP label Apr 13, 2017

Breaking changes work #1

b6a12d2

BillWagner requested changes Apr 17, 2017

View reviewed changes

Luke Latham added 2 commits April 17, 2017 15:57

Fix merge conflict

6ed6c47

Updates

d6aa104

guardrex removed the WIP label Apr 17, 2017

mairaw reviewed Apr 27, 2017

View reviewed changes

React to feedback

510251f

BillWagner requested changes Apr 27, 2017

View reviewed changes

React to feedback

ebd1a60

Revert Docker for Windows removal

9bf86d9

Add note to install .NET Core workload with VS

5050f55

BillWagner approved these changes May 1, 2017

View reviewed changes

guardrex merged commit 50e1281 into dotnet:master May 1, 2017

guardrex deleted the guardrex/remove-vs-version-references-vs2013 branch May 1, 2017 18:51

BillWagner added dotnet-csharp/svc and removed 📚 Area - C# Guide labels Feb 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing outdated VS references (Part 3) #1811

Removing outdated VS references (Part 3) #1811

guardrex commented Mar 28, 2017 •

edited

Loading

dnfclas commented Mar 28, 2017

mairaw left a comment

mairaw Mar 29, 2017

guardrex Apr 14, 2017

mairaw Mar 29, 2017

BillWagner Apr 17, 2017

mairaw Apr 27, 2017

rpetrusha Apr 11, 2017

guardrex commented Apr 11, 2017

BillWagner Apr 17, 2017

guardrex Apr 17, 2017

mairaw Apr 18, 2017

guardrex Apr 19, 2017

mairaw Apr 27, 2017

guardrex commented Apr 17, 2017

mairaw left a comment

mairaw Apr 27, 2017

mairaw Apr 27, 2017

mairaw Apr 27, 2017

guardrex commented Apr 27, 2017

BillWagner left a comment

BillWagner Apr 27, 2017

guardrex commented Apr 27, 2017

BillWagner commented Apr 27, 2017

guardrex commented Apr 27, 2017

guardrex commented Apr 27, 2017

guardrex commented Apr 27, 2017 •

edited

Loading

mairaw commented Apr 27, 2017

guardrex commented Apr 27, 2017 •

edited

Loading

guardrex commented Apr 27, 2017

BillWagner commented Apr 28, 2017

mairaw commented May 1, 2017

Removing outdated VS references (Part 3) #1811

Removing outdated VS references (Part 3) #1811

Conversation

guardrex commented Mar 28, 2017 • edited Loading

dnfclas commented Mar 28, 2017

mairaw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guardrex commented Apr 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guardrex commented Apr 17, 2017

mairaw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guardrex commented Apr 27, 2017

BillWagner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guardrex commented Apr 27, 2017

BillWagner commented Apr 27, 2017

guardrex commented Apr 27, 2017

guardrex commented Apr 27, 2017

guardrex commented Apr 27, 2017 • edited Loading

mairaw commented Apr 27, 2017

guardrex commented Apr 27, 2017 • edited Loading

guardrex commented Apr 27, 2017

BillWagner commented Apr 28, 2017

mairaw commented May 1, 2017

guardrex commented Mar 28, 2017 •

edited

Loading

guardrex commented Apr 27, 2017 •

edited

Loading

guardrex commented Apr 27, 2017 •

edited

Loading