Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to the CI document #1556

Closed
wants to merge 14 commits into from
12 changes: 11 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,21 @@ matrix:
- os: osx # OSX 10.11
osx_image: xcode7.2
dotnet: 1.0.0-preview2-003121
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to change these versions @enricosada?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That should say 1.0.1

- os: osx # OSX 10.12
osx_image: xcode7.3
dotnet: 1.0.0-rc4-0044771
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please CMIIW, but I think it's 0044771 -> 004771.

It will work after travis-ci/travis-build#973 :)


## If `dotnet` configuration doesnt work, use install script instead
# install:
# - export DOTNET_INSTALL_DIR="$PWD/.dotnetsdk"
# - curl -sSL https://raw.githubusercontent.com/dotnet/cli/rel/1.0.0/scripts/obtain/dotnet-install.sh | bash /dev/stdin --version "$CLI_VERSION" --install-dir "$DOTNET_INSTALL_DIR"
# - export PATH="$DOTNET_INSTALL_DIR:$PATH"

script:
- dotnet --info
# Run a new console app
- mkdir -p "test/test-dotnet-new" && pushd "test/test-dotnet-new"
- dotnet new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be changed to dotnet new console

- dotnet restore
- dotnet --verbose run a b
- dotnet run a b
- popd
36 changes: 15 additions & 21 deletions appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,33 +1,27 @@
os: Visual Studio 2015

## .NET Core SDK preview1 is already installed in the build worker image Visual Studio 2015
##
## To install a specific version:
##
## install:
## # .NET Core SDK binaries
## ## 1) from direct url
## - ps: $url = "https://go.microsoft.com/fwlink/?LinkID=798402" # v1.0.0-preview1 x64
## ## 2) from url based on version, for example using an env var CLI_VERSION that can be a
## ## a specific version `1.0.0-preview2-003121` or `Latest` (for latest dev version)
## - ps: $url = "https://dotnetcli.blob.core.windows.net/dotnet/preview/Binaries/$($env:CLI_VERSION)/dotnet-dev-win-x64.$($env:CLI_VERSION.ToLower()).zip"
## # Download .NET Core SDK and add to PATH
## - ps: $env:DOTNET_INSTALL_DIR = "$pwd\.dotnetsdk"
## - ps: mkdir $env:DOTNET_INSTALL_DIR -Force | Out-Null
## - ps: $tempFile = [System.IO.Path]::GetTempFileName()
## - ps: (New-Object System.Net.WebClient).DownloadFile($url, $tempFile)
## - ps: Add-Type -AssemblyName System.IO.Compression.FileSystem; [System.IO.Compression.ZipFile]::ExtractToDirectory($tempFile, $env:DOTNET_INSTALL_DIR)
## - ps: $env:Path = "$env:DOTNET_INSTALL_DIR;$env:Path"
# NOTE .NET Core SDK preview2 is already installed in the build worker image Visual Studio 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would need to update these for vs 2017 correct?

# so the `install` section is not required

environment:
CLI_VERSION: 1.0.0-rc4-004771

install:
- ps: $env:DOTNET_INSTALL_DIR = "$pwd\.dotnetsdk"
- ps: mkdir $env:DOTNET_INSTALL_DIR -Force | Out-Null
- ps: Invoke-WebRequest -Uri "https://raw.githubusercontent.com/dotnet/cli/rel/1.0.0/scripts/obtain/dotnet-install.ps1" -OutFile "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1"
- ps: '& "$($env:DOTNET_INSTALL_DIR)/dotnet-install.ps1" -Version $env:CLI_VERSION -InstallDir $env:DOTNET_INSTALL_DIR'
- ps: $env:Path = "$env:DOTNET_INSTALL_DIR;$env:Path"

build_script:
# dotnet info
- ps: dotnet --info
# Run dotnet new
- ps: mkdir "test\test-dotnet-new" -Force | Push-Location
- ps: dotnet new --lang fsharp
- ps: dotnet new console -lang f#
- ps: dotnet restore
- ps: dotnet --verbose build
- ps: dotnet --verbose run a b
- ps: dotnet build
- ps: dotnet run a b
- ps: Pop-Location


Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
188 changes: 143 additions & 45 deletions docs/core/preview3/tools/using-ci-with-cli.md

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions docs/toc.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@
### [Additions to the csproj format](core/preview3/tools/csproj.md)
### [Telemetry](core/preview3/tools/telemetry.md)
### [Extensibility Model](core/preview3/tools/extensibility.md)
### [Continuous Integration](core/preview3/tools/using-ci-with-cli.md)
### [dotnet](core/preview3/tools/dotnet.md)
### [dotnet-new](core/preview3/tools/dotnet-new.md)
### [dotnet-migrate](core/preview3/tools/dotnet-migrate.md)
Expand Down