Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish template assets as NuGet contentFiles #8307

Merged
merged 3 commits into from
Dec 23, 2022

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Dec 22, 2022

Ship template files using NuGet contentFiles for stock templates and memberpage.

  • Template files are copied to {AppContext.BaseDirectory}/templates/{template-name} on build:
    • CopyToOutputDirectory enables copy when used as <ProjectReference>
    • PackageCopyToOutput enables copy when used as <PackageReference>
  • Stop shipping templates as embedded zip archives.

To use memberpage plugin, add package reference to Microsoft.DocAsCode.Build.MemberLevelManagedReference and change templates to ["default", "memberpage"]

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 72.91% // Head: 73.22% // Increases project coverage by +0.31% 🎉

Coverage data is based on head (456388c) compared to base (5279a0f).
Patch coverage: 57.14% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8307      +/-   ##
==========================================
+ Coverage   72.91%   73.22%   +0.31%     
==========================================
  Files         955      955              
  Lines       38627    38627              
  Branches     7186     7187       +1     
==========================================
+ Hits        28164    28284     +120     
+ Misses       8334     8215     -119     
+ Partials     2129     2128       -1     
Impacted Files Coverage Δ
src/docfx/SubCommands/TemplateCommand.cs 0.00% <0.00%> (ø)
...Microsoft.DocAsCode.Build.Engine/ResourceFinder.cs 88.00% <100.00%> (+1.63%) ⬆️
...ngine/ResourceFileReaders/ArchiveResourceReader.cs 48.48% <0.00%> (-42.43%) ⬇️
...velManagedReference/SplitClassPageToMemberLevel.cs 83.82% <0.00%> (+1.65%) ⬆️
...ft.DocAsCode.Build.RestApi/BuildRestApiDocument.cs 90.62% <0.00%> (+3.12%) ⬆️
src/Microsoft.DocAsCode.Common/Git/GitUtility.cs 71.65% <0.00%> (+3.74%) ⬆️
...tadata.ManagedReference/MsBuildEnvironmentScope.cs 26.53% <0.00%> (+6.12%) ⬆️
...sCode.YamlSerialization/Helpers/ArrayDictionary.cs 93.75% <0.00%> (+6.25%) ⬆️
...dReference/ExtractMetadata/ProjectDocumentCache.cs 58.33% <0.00%> (+8.33%) ⬆️
...Metadata.ManagedReference/ExtractMetadataWorker.cs 65.31% <0.00%> (+12.91%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Dec 23, 2022
@yufeih yufeih merged commit 87a9c05 into main Dec 23, 2022
@yufeih yufeih deleted the feature/template-in-folder branch December 23, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant