Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go net6 follow up3 #8254

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Go net6 follow up3 #8254

merged 2 commits into from
Dec 7, 2022

Conversation

tibel
Copy link
Contributor

@tibel tibel commented Dec 2, 2022

apply changes from branch yufeih/net6test

@paulushub
Copy link

These .NET 6 changes are enough to merit a version bump up to 2.6.0, and dropping packages like
Microsoft.DocAsCode.MarkdownLite for simplifications.

yufeih
yufeih approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I didn't commit because of test failures but we can make the build work first

@yufeih yufeih merged commit fe58088 into dotnet:dev Dec 7, 2022
@yufeih
Copy link
Contributor

yufeih commented Dec 7, 2022

These .NET 6 changes are enough to merit a version bump up to 2.6.0, and dropping packages like Microsoft.DocAsCode.MarkdownLite for simplifications.

There are some test failures in the .NET 6 version, these PRs only make build pass. Some tricky failures related to Microsoft.CodeAnalysis may took time to investigate and fix.

@tibel tibel deleted the go-net6-follow-up3 branch December 7, 2022 10:10
@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufeih yufeih yufeih approved these changes

Assignees
No one assigned
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tibel @paulushub @yufeih