This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix a issue where ETW was losing RCW and CCW in heap dumps. #7971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically our builk events for RCWs and CCWs were too big, causing ETW to reject them, and thus losing information. However you have to have at least several hundred befor you have enough to force the problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically our builk events for RCWs and CCWs were too big, causing ETW to reject them, and thus losing information.
However you have to have at least several hundred befor you have enough to force the problem.
I have an ad-hoc test case that confirms the fix works.
The fix is trivial. Lower the cutoff used to determine how many bulk items will be placed in a single ETW event.
@brianrob @daklimek