This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix current publish build warnings #11317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
changed the title
|
Thanks! Merging now without CI complete because CI doesn't use the pipebuild files. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up publish build warnings.
CoreCLR publishes two Drops, one named by OfficialBuildId, another by BuildNumber. Having both makes it so you don't need to translate from one to another to find a CoreCLR build's Drop.
When the
dropMetadataContainerNameis the same, the later step fails. (This was only a warning because the step is "continue on error".) The metadata name is used to create a VSTS Artifact. I changed the metadata name based on what the Drop is named after.Remove "Copy Publish Artifact: PublishLogs" because there are no *.log files being created during the publish build. There is only a
init-tools.cmdcall and directmsbuildinvocations.