Fixed Readme for AssertFunction Call Case #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dop251
reviewed
Jul 6, 2023
| @@ -171,8 +171,8 @@ There are 2 approaches: | |||
| - Using [AssertFunction()](https://pkg.go.dev/github.com/dop251/goja#AssertFunction): | |||
| ```go | |||
| const SCRIPT = ` | |||
| function f(param) { | |||
| return +param + 2; | |||
| function sum(a, b) { | |||
There was a problem hiding this comment.
This was changed by #511 to make it more consistent with the following example. What I didn't realise is that the rest of the example was not changed. I think it's better to do that instead.
There was a problem hiding this comment.
Looks it #511 wrapped script body into a constant and adjusted the function body it self. Yet didn't sync the refer usage part.
With following the consistency idea I've turned both the examples to use the same more meaningful function sum (which might be more clear to grasp the logic) with the same notation and the same usage holder variables.
kudla
force-pushed
the
fix-assert-function-readme
branch
from
473fd9f
to
11c1ee7
Compare
Gabri3l
pushed a commit
to Gabri3l/goja
that referenced
this pull request
Sep 20, 2023
* Fixed Readme for AssertFunction Call Case * Made Consistent Both func Variable Name and Logic for Function Calling Examples (cherry picked from commit 636fdf9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.