Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] eth_getStorageAt always returning 0 #353

Conversation

0xcb9ff9
Copy link

Description

upstream PR: #1546, #1558

The RLP Parsing is already being done by the Snapshot's GetStorage method

Changes include

  • Bugfix (non-breaking change that solves an issue)

Breaking changes

eth_getStorageAt result change

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

@0xcb9ff9 0xcb9ff9 added the bug fix Functionality that fixes a bug label Jun 17, 2023
@0xcb9ff9 0xcb9ff9 self-assigned this Jun 17, 2023
@0xcb9ff9 0xcb9ff9 changed the title [fix] eth_getStorageAt always returning 0 [Fix] eth_getStorageAt always returning 0 Jun 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #353 (ff74d14) into dev (c202b4e) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #353      +/-   ##
==========================================
- Coverage   47.66%   47.60%   -0.07%     
==========================================
  Files         136      136              
  Lines       20603    20592      -11     
==========================================
- Hits         9820     9802      -18     
- Misses       9954     9958       +4     
- Partials      829      832       +3     
Impacted Files Coverage Δ
jsonrpc/eth_endpoint.go 71.38% <100.00%> (+0.42%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@DarianShawn DarianShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution.

@DarianShawn DarianShawn merged commit e72704b into dogechain-lab:dev Jun 17, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2023
@0xcb9ff9 0xcb9ff9 deleted the upstream/EVM-522-get-storage-should-return-parsed-data branch June 17, 2023 06:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants