[blockchain] Exclude zero values from gas price metrics #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #337 +/- ##
==========================================
+ Coverage 47.37% 47.48% +0.11%
==========================================
Files 135 135
Lines 20440 20451 +11
==========================================
+ Hits 9683 9711 +28
+ Misses 9919 9908 -11
+ Partials 838 832 -6
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The maximum and average gas price metrics were disturbed by the zero values of the system contract transaction. With zero values adopted, they do not accurately reflect actual user gas prices.
The PR fixes this, by removing miner transactions from transaction count, and providing price bottom limit to metric collector when no user transactions are included.
Changes include
Testing