-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[network] Feature: support static node #280
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #280 +/- ##
==========================================
- Coverage 51.21% 47.88% -3.33%
==========================================
Files 117 127 +10
Lines 17525 19420 +1895
==========================================
+ Hits 8975 9300 +325
- Misses 7789 9329 +1540
- Partials 761 791 +30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
Only a few suggestions here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great job 🙌
Description
this PR add static node feature, static nodes configured for normal node not remove on runtime. unlike bootnode, node connections to static nodes is keep alive, if the connection is disconnected, node will actively try to reconnect static node (management connections is not affected by this PR)
command change
dogechain genesis
add--staticnode
Flagstaticnodes
fielddogechain peers add
add--static
Flag, dynamically add static nodesgenesis file simple:
Changes include
Checklist
Testing
Manual tests