Update gitignore

[thaJeztah]

Adding some lines from the Moby gitignore

@dnephin @vdemeester for consideration; not sure if these would qualify as "should be present in your global ignore" as well

[codecov-io]

Codecov Report

Merging #536 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #536      +/-   ##
=========================================
+ Coverage    49.4%   49.4%   +<.01%     
=========================================
  Files         208     208              
  Lines       17159   17159              
=========================================
+ Hits         8477    8478       +1     
+ Misses       8249    8248       -1     
  Partials      433     433

[vdemeester]

LGTM 🐯

[albers]

The custom .bashrc only works in the context of the moby/moby build scripts: https://github.com/moby/moby/blob/master/Dockerfile#L179. There's no corresponding feature in this repo.

[thaJeztah]

Ah, yes, makes sense, I can remove that, thanks 👍

[thaJeztah]

Updated, PTAL 😅

[dnephin]

None of these files are created by this repo, or they are already ignored by other rules (ex .exe should be in build/

I guess we could add these, but why?

[thaJeztah]

To prevent things like #535

[vdemeester]

@dnephin @thaJeztah what is the current status of this ? 👼

[dnephin]

I think generally .gitignore should only include files that are created by a project, or are documented by the project, but should not be added to git. Other files should be ignored by the user.

I don't think adding these lines fixes the problem.

[vdemeester]

@dnephin although I agree, part of them can be created by the project (*.exe, the file ending with ~ or *.swp when editing with vim or else, …) and I really think it doesn't really hurt to add them…

… and the PR is stuck since September, it's creeping me out. So I'll go ahead and merge it and if we feel something wrong with it we can remove some of them 👼