Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test by using a pinned version of alpine #532

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Sep 14, 2017

Fixes this test failure on master, caused by a repin of alpine:3.6. This is now using a digest to pull a specific version of alpine so we shouldn't run in to this problem again.

22:44:11 === RUN   TestRunAttachedFromRemoteImageAndRemove
22:44:11 --- FAIL: TestRunAttachedFromRemoteImageAndRemove (0.72s)
22:44:11 		
	            	-Digest: sha256:0930dd4cc97ed5771ebe9be9caf3e8dc5341e0b5e32e8fb143394d7dfdfa100e
22:44:11 		
	            	+Digest: sha256:641b95ddb2ea9dc2af1a0113b6b348ebc20872ba615204fbe12148e98fd6f23d
22:44:11 		
	            	 Status: Downloaded newer image for registry:5000/alpine:test-run-pulls
22:44:11 		
22:44:11 FAIL
22:44:11 FAIL	github.com/docker/cli/e2e/container	0.721s

@codecov-io
Copy link

Codecov Report

Merging #532 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #532   +/-   ##
=======================================
  Coverage   49.05%   49.05%           
=======================================
  Files         200      200           
  Lines       16398    16398           
=======================================
  Hits         8044     8044           
  Misses       7935     7935           
  Partials      419      419

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 9053aa1 into docker:master Sep 15, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.10.0 milestone Sep 15, 2017
@dnephin dnephin deleted the fix-e2e-fixture branch September 15, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants