Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bash completion for --credential-spec #352

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

albers
Copy link
Collaborator

@albers albers commented Jul 18, 2017

This option is Windows specific and should only be available if the daemon runs on Windows.
Ref: #338

@codecov-io
Copy link

codecov-io commented Jul 18, 2017

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   47.39%   47.39%           
=======================================
  Files         199      199           
  Lines       16405    16405           
=======================================
  Hits         7775     7775           
  Misses       8233     8233           
  Partials      397      397

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This option is Windows specific and should be only available if the
daemon runs on Windows.

Signed-off-by: Harald Albers <[email protected]>
@albers albers force-pushed the fix-completion--credential-spec branch from c395687 to 056ccf8 Compare August 28, 2017 07:55
@albers
Copy link
Collaborator Author

albers commented Aug 30, 2017

@mlaventure Would you mind reviewing this PR? It's been hanging around for several weeks now.

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@vdemeester vdemeester merged commit 16804b7 into docker:master Sep 20, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.10.0 milestone Sep 20, 2017
@albers albers deleted the fix-completion--credential-spec branch September 20, 2017 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants