Clarifying docker config rules

[adrian-plata]

https://docs.docker.com/engine/reference/commandline/cli/

Signed-off-by: Adrian Plata [email protected]

[adrian-plata]

@andrewhsu and @thaJeztah PTAL. This is an attempt to clarify where the .docker/config.json file location is.

[codecov-io]

Codecov Report

Merging #2077 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2077   +/-   ##
=======================================
  Coverage   56.79%   56.79%           
=======================================
  Files         311      311           
  Lines       21836    21836           
=======================================
  Hits        12402    12402           
  Misses       8519     8519           
  Partials      915      915

[codecov-io]

Codecov Report

Merging #2077 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2077      +/-   ##
==========================================
+ Coverage   56.78%   56.79%   +<.01%     
==========================================
  Files         311      311              
  Lines       21839    21836       -3     
==========================================
  Hits        12402    12402              
+ Misses       8522     8519       -3     
  Partials      915      915

[adrian-plata]

Added information on enabling experimental features.

[andrewhsu]

I left some comments. I think a future PR could break up the https://docs.docker.com/engine/reference/commandline/cli/#configuration-files section into sub headings with experimental being one of them.

[thaJeztah]

Thanks! left some comments

[thaJeztah]

Perhaps in this location, we should explain that the --config flag is only applying to the command that's run (i.e., it's not updating the default configuration, and only applies to the command that you ran with that flag set).

After explaining that, I think we should add a second example that's using the DOCKER_CONFIG environment variable; we can show that example using export DOCKER_CONFIG=........, and below the example add a note that if they want to persist that configuration, they can set it in, e.g. their ~/.profile (or ~/.bashrc, or whatever flavour of shell they're using)

[adrian-plata]

Can you expand on the second example more?

[adrian-plata]

I took a shot at the command, how does it look @thaJeztah ?

[thaJeztah]

left two comments, otherwise LGTM

[thaJeztah]

I think this is missing an echo

Suggested change

	export DOCKER_CONFIG=$HOME/newdir/.docker > ~/.profile
	echo export DOCKER_CONFIG=$HOME/newdir/.docker > ~/.profile

[thaJeztah]

We should probably link to the docs.docker.com site instead (otherwise, once this is published on docs.docker.com, we direct people to GitHub instead of staying on docs.docker.com);

Suggested change

	[Docker Desktop Getting Started page](https://github.com/docker/docker.github.io/blob/master/docker-for-mac/index.md#experimental-features)
	[Docker Desktop Getting Started page](https://docs.docker.com/docker-for-mac/#experimental-features)

[thaJeztah]

LGTM, thanks!