Add "bashbrew fetch" command #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many, many, many scripts I have encoded the horrible assumption that `ArchDockerFroms` will ensure our Git repository is fetched (which is a side-effect of that function). With the implementation of `Builder: oci-import`, that side effect is not necessary for returning an accurate result in these new images. Instead of working around this in bad ways, I've decided to finally bite the bullet and add an explicit `bashbrew fetch` command that can make sure all the underlying Git commits are fully fetched into the local cache.
This not only returns the path to the "git cache" directory, but ensures it is initialized and that `git` commands against it will generally succeed.
tianon
commented
Jan 30, 2023
Comment on lines
+59
to
+65
| "gitCache": func() (string, error) { | ||
| err := ensureGitInit() | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| return gitCache(), nil | ||
| }, |
There was a problem hiding this comment.
This one added function covers at least 95% of the cases where I set BASHBREW_CACHE in scripts 🙈
It also removes the need for bashbrew from hello-world that I do in a lot of those place (whose purpose is just to make sure ensureGitInit has been invoked 😭).
yosifkit
approved these changes
Jan 31, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 73.10% 73.10%
=======================================
Files 7 7
Lines 714 714
=======================================
Hits 522 522
Misses 162 162
Partials 30 30 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many, many, many scripts I have encoded the horrible assumption that
ArchDockerFromswill ensure our Git repository is fetched (which is a side-effect of that function). With the implementation ofBuilder: oci-import, that side effect is not necessary for returning an accurate result in these new images. Instead of working around this in bad ways, I've decided to finally bite the bullet and add an explicitbashbrew fetchcommand that can make sure all the underlying Git commits are fully fetched into the local cache.