Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of System.out + proper error logging #3572

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

tovbinm
Copy link
Contributor

@tovbinm tovbinm commented Aug 9, 2018

Related to #3570

@CodingCat
Copy link
Member

LGTM, Thanks!

please add [jvm-packages] in your title when you modify jvm-package files,

@codecov-io
Copy link

codecov-io commented Aug 9, 2018

Codecov Report

Merging #3572 into master will increase coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3572      +/-   ##
============================================
+ Coverage     48.04%   48.15%   +0.11%     
  Complexity      188      188              
============================================
  Files           169      169              
  Lines         13345    13341       -4     
  Branches        457      457              
============================================
+ Hits           6412     6425      +13     
+ Misses         6708     6691      -17     
  Partials        225      225
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/ml/dmlc/xgboost4j/java/Booster.java 55.19% <0%> (+1.18%) 34 <0> (ø) ⬇️
src/data/sparse_page_dmatrix.cc 92.89% <0%> (+0.59%) 0% <0%> (ø) ⬇️
src/data/sparse_page_raw_format.cc 64.15% <0%> (+22.64%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb771f...3084c58. Read the comment docs.

@hcho3 hcho3 merged commit bad7604 into dmlc:master Aug 9, 2018
@hcho3
Copy link
Collaborator

hcho3 commented Aug 9, 2018

@tovbinm Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants