(Minor) Fix in SparkParallelTracker to work with Spark2.3 #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd say it's OK not to support 1.6.X. What do you think @CodingCat? |
|
we do not support spark 1.x in anyway since we have integrated with Spark 2.x ML pipeline |
Codecov Report
@@ Coverage Diff @@
## master #3062 +/- ##
============================================
+ Coverage 43.72% 43.72% +<.01%
Complexity 228 228
============================================
Files 159 159
Lines 12351 12352 +1
Branches 466 466
============================================
+ Hits 5400 5401 +1
Misses 6759 6759
Partials 192 192
Continue to review full report at Codecov.
|
|
We'll need to detail this in the docs, I guess. Thanks @tomasatdatabricks! |
hcho3
pushed a commit
that referenced
this pull request
Aug 13, 2018
This pull request amends the broken #3062 allow Spark 2.2 to work. Please note this won't work in Spark <=2.1 as sc.removeSparkListener was implemented in Spark 2.2. (So perhaps a more general method is better, although that is what was attempted in #3062) This PR fixes: #3208, #3151 and the discussion in #1927. I do find it strange that #3062 dose not work in Spark 2.2, it's probably due to some sort of public/private issue in the org.apache.spark.scheduler.LiveListenerBus class inheritance (In Spark itself). The error is: `java.lang.NoSuchMethodError: org.apache.spark.scheduler.LiveListenerBus.removeListener(Ljava/lang/Object;)V`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how xgboost registers and removes Listeners to SparkContext so that it works on Spark2.3 while it continues to work on versions of Spark >= 2.0.
Spark 2.3 includes changes in LiveListenerBus which are incompatible with xgboost's SparkParallelTracker - the SparkContext::listenerBus member variable changed type and it is no longer possible to register or deregister listeners by directly accessing list of listeners in it. I've changed it so that listener is registered via public method on SparkContext. The public method for removing listener has been added only in Spark2.3 and in order to run on older versions of Spark I still call the method on the listenerBus instance.
This change means xgboost will not compile against/ run on spark version < 2.0.