Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build failure message #2397

Merged
merged 2 commits into from
Jun 26, 2017
Merged

Add build failure message #2397

merged 2 commits into from
Jun 26, 2017

Conversation

yvn11
Copy link
Contributor

@yvn11 yvn11 commented Jun 9, 2017 •
edited
Loading

build script shown 'Successfully build' message when it actually failed.

@superbobry
Copy link
Contributor

Ideally, you should also do set -e at the beginning of the build script to make it fail on error. See #2356.

@terrytangyuan terrytangyuan merged commit 9bcbaa8 into dmlc:master Jun 26, 2017
CodingCat added a commit that referenced this pull request Jun 26, 2017
@CodingCat
Revert "Add build failure message (#2397)"
ccc62ad 
This reverts commit 9bcbaa8.
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvn11 @superbobry @terrytangyuan