Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue when hd_match.group(1) == false while hd_match.group(2) is None #14

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Fix the issue when hd_match.group(1) == false while hd_match.group(2) is None #14

merged 1 commit into from
Dec 15, 2016

Conversation

haoliang-quan
Copy link
Contributor

So sorry for introducing the bug. The issue was, when hdUrl is set to false, hd_match.group(2) will still exist, but with the value None. In our old code, this will simply cause an exception and skip all the following logic for downloading a regular video. That means, the old code will only work for HD videos.

The fix first checks if hdUrl is false, if not, tries to download the HD video. Otherwise, still downloads the regular video.

@haoliang-quan
Copy link
Contributor Author

@kyeolee89 please check if this fix the issue #12 .

@kyeolee89
Copy link
Contributor

@hquan Thanks, And the 63th line does not contain line breaks in the regular expression, so it is not processed. You must modify it to include line breaks with the "re.DOTALL" option. Please Check it.

@dixudx dixudx merged commit 8934084 into dixudx:master Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants