Fix the issue when hd_match.group(1) == false while hd_match.group(2) is None #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So sorry for introducing the bug. The issue was, when
hdUrl
is set tofalse
,hd_match.group(2)
will still exist, but with the valueNone
. In our old code, this will simply cause an exception and skip all the following logic for downloading a regular video. That means, the old code will only work for HD videos.The fix first checks if
hdUrl
isfalse
, if not, tries to download the HD video. Otherwise, still downloads the regular video.