bug: force json body if json and remove excess headers

divshot · Oct 10, 2014 · 51f630c · 51f630c
1 parent 8d78118
commit 51f630c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -32,6 +32,8 @@ module.exports = function () {
 
     // Remove request origin
     delete req.headers.host;
+    delete req.headers.origin; // TODO: test this
+    delete req.headers.referer; // TODO: test this
 
     stack.use(bodyParser.json());
     stack.use(bodyParser.raw());
@@ -47,7 +49,15 @@ module.exports = function () {
         timeout: (config.timeout)*1000 || DEFAULT_TIMEOUT
       };
 
-      if (req.body) options.body = JSON.stringify(req.body);
+      if (req.body && Object.keys(req.body).length > 0)  {
+        try {
+          var body = JSON.parse(req.body);
+          options.json = true;
+        }
+        catch (e) {}
+
+        options.body = JSON.stringify(req.body);
+      }
 
       request(options).pipe(res);
     });

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "superstatic-proxy",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "A Superstatic service for HTTP proxying of AJAX requests",
   "main": "index.js",
   "directories": {

diff --git a/test/index.js b/test/index.js
@@ -85,6 +85,17 @@ describe('Superstatic Proxy', function () {
       .end(done);
   });
 
+  it('proxies a DELETE request', function (done) {
+
+    request(app)
+      .delete('/__/proxy/api/users.json')
+      .expect(200)
+      .expect(function (data) {
+        expect(data.res.body.method).to.equal('DELETE');
+      })
+      .end(done);
+  });
+
   it('proxies a request, ignoring the proxy name case', function (done) {
     request(app)
       .post('/__/proxy/Api/users.json')