-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SelectMenuInteractions): add values
property
#8805
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise this is LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more nits on top of space's review
packages/discord.js/src/structures/MentionableSelectMenuInteraction.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/ChannelSelectMenuInteraction.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/RoleSelectMenuInteraction.js
Outdated
Show resolved
Hide resolved
packages/discord.js/src/structures/UserSelectMenuInteraction.js
Outdated
Show resolved
Hide resolved
…into fix-newselects
packages/discord.js/src/structures/MentionableSelectMenuInteraction.js
Outdated
Show resolved
Hide resolved
…ction.js Co-authored-by: Aura Román <[email protected]>
values
property
values
propertyvalues
property
Codecov Report
@@ Coverage Diff @@
## main #8805 +/- ##
==========================================
- Coverage 85.61% 85.59% -0.02%
==========================================
Files 96 95 -1
Lines 9459 9446 -13
Branches 1134 1129 -5
==========================================
- Hits 8098 8085 -13
Misses 1319 1319
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please describe the changes this PR makes and why it should be merged:
Add values property to interactions
And stop members, roles displaying as null ( as they cant be )
Status and versioning classification: