♻️ [QSP-BestPractices] Rename withdrawalQueue to withdrawalStack (Rar…

…i-Capital#107)

.gas-snapshot

@@ -1,53 +1,53 @@
-testIntegration() (gas: 5161721)
-testFailDeposit() (gas: 81022)
-testInitializeAndDeposit() (gas: 173445)
-testTrustStrategyWithWETHUnderlying() (gas: 28101)
-testTrustStrategyWithETHUnderlying() (gas: 27497)
-testAtomicDepositWithdrawIntoETHStrategies() (gas: 618456)
-testDestroyVaultReturnsETH() (gas: 13393)
-testFailWithdrawFromStrategyWithNotEnoughBalance() (gas: 298662)
-testAtomicDepositRedeem() (gas: 203726)
-testUpdatingHarvestDelay() (gas: 78752)
-testAtomicEnterExitSinglePool() (gas: 379520)
-testFailDepositIntoStrategyZero() (gas: 28412)
-testFailHarvestUntrustedStrategy() (gas: 324967)
-testFailWithdrawFromStrategyZero() (gas: 28473)
-testAtomicDepositWithdraw() (gas: 203748)
-testDestroyVault() (gas: 6352)
-testWithdrawingWithUntrustedStrategyInQueue() (gas: 1784365)
-testPushingToWithdrawalQueue() (gas: 131253)
-testFailSeizeUntrustedStrategy() (gas: 301477)
-testFailDepositIntoStrategyWithNoBalance() (gas: 129193)
-testFailRedeemWithNotEnoughBalance() (gas: 152301)
-testUnprofitableHarvest() (gas: 542644)
-testFailDepositWithNotEnoughApproval() (gas: 120640)
-testFailDepositIntoStrategyWithNotEnoughBalance() (gas: 272209)
-testSeizeStrategyWithBalanceGreaterThanTotalAssets() (gas: 483108)
-testFailWithdrawFromStrategyWithNoBalance() (gas: 28740)
-testFailRedeemZero() (gas: 1180)
-testClaimFees() (gas: 201265)
-testFailWithdrawWithNotEnoughBalance() (gas: 152358)
-testSeizeStrategy() (gas: 436518)
-testReplaceWithdrawalQueueIndex() (gas: 126351)
-testFailWithdrawWithIncompleteQueue() (gas: 517847)
+testIntegration() (gas: 5162307)
+testFailDeposit() (gas: 80977)
+testInitializeAndDeposit() (gas: 173443)
+testTrustStrategyWithWETHUnderlying() (gas: 28056)
+testTrustStrategyWithETHUnderlying() (gas: 27452)
+testAtomicDepositWithdrawIntoETHStrategies() (gas: 618609)
+testDestroyVaultReturnsETH() (gas: 13350)
+testFailWithdrawFromStrategyWithNotEnoughBalance() (gas: 298683)
+testAtomicDepositRedeem() (gas: 203607)
+testUpdatingHarvestDelay() (gas: 78748)
+testAtomicEnterExitSinglePool() (gas: 379507)
+testFailDepositIntoStrategyZero() (gas: 28434)
+testFailHarvestUntrustedStrategy() (gas: 324944)
+testFailWithdrawFromStrategyZero() (gas: 28495)
+testAtomicDepositWithdraw() (gas: 203628)
+testDestroyVault() (gas: 6309)
+testFailSeizeUntrustedStrategy() (gas: 301497)
+testFailDepositIntoStrategyWithNoBalance() (gas: 129171)
+testWithdrawingWithUntrustedStrategyInStack() (gas: 1784630)
+testFailRedeemWithNotEnoughBalance() (gas: 152279)
+testUnprofitableHarvest() (gas: 542421)
+testPoppingFromWithdrawalStack() (gas: 146997)
+testPushingToWithdrawalStack() (gas: 131520)
+testFailDepositWithNotEnoughApproval() (gas: 120551)
+testFailDepositIntoStrategyWithNotEnoughBalance() (gas: 272208)
+testSeizeStrategyWithBalanceGreaterThanTotalAssets() (gas: 483104)
+testWithdrawingWithDuplicateStrategiesInStack() (gas: 667409)
+testFailWithdrawFromStrategyWithNoBalance() (gas: 28739)
+testFailRedeemZero() (gas: 1202)
+testFailWithdrawWithEmptyStack() (gas: 310413)
+testClaimFees() (gas: 200954)
+testFailWithdrawWithNotEnoughBalance() (gas: 152247)
+testSeizeStrategy() (gas: 436511)
 testFailTrustStrategyWithETHUnderlying() (gas: 968005)
-testProfitableHarvest() (gas: 579291)
-testFailDepositZero() (gas: 1166)
-testFailWithdrawWithNoBalance() (gas: 3678)
-testPoppingFromWithdrawalQueue() (gas: 146491)
-testFailWithdrawZero() (gas: 1204)
-testWithdrawingWithDuplicateStrategiesInQueue() (gas: 667166)
-testFailHarvestAfterWindowBeforeDelay() (gas: 472375)
-testFailInitializeTwice() (gas: 1580)
-testMultipleHarvestsInWindow() (gas: 526483)
-testFailWithdrawFromStrategyWithoutTrust() (gas: 301511)
-testFailDepositWithNoApproval() (gas: 50405)
-testFailRedeemWithNoBalance() (gas: 3684)
-testAtomicEnterExitMultiPool() (gas: 520788)
-testReplaceWithdrawalQueueIndexWithTip() (gas: 128221)
-testFailTrustStrategyWithWrongUnderlying() (gas: 1936765)
-testSwapWithdrawalQueueIndexes() (gas: 128672)
-testFailWithdrawWithEmptyQueue() (gas: 310499)
+testProfitableHarvest() (gas: 578902)
+testFailWithdrawWithIncompleteStack() (gas: 517890)
+testFailDepositZero() (gas: 1165)
+testFailWithdrawWithNoBalance() (gas: 3632)
+testFailWithdrawZero() (gas: 1203)
+testReplaceWithdrawalStackIndexWithTip() (gas: 128205)
+testReplaceWithdrawalStackIndex() (gas: 126450)
+testFailHarvestAfterWindowBeforeDelay() (gas: 472418)
+testFailInitializeTwice() (gas: 1514)
+testMultipleHarvestsInWindow() (gas: 526501)
+testFailWithdrawFromStrategyWithoutTrust() (gas: 301576)
+testFailDepositWithNoApproval() (gas: 50338)
+testFailRedeemWithNoBalance() (gas: 3640)
+testAtomicEnterExitMultiPool() (gas: 520815)
+testFailTrustStrategyWithWrongUnderlying() (gas: 1936698)
+testSwapWithdrawalStackIndexes() (gas: 128676)
 testSetRoles() (gas: 33303)
 testCanCallWithCustomAuthorityOverridesPublicCapability() (gas: 133778)
 testCanCallPublicCapability() (gas: 40166)
@@ -57,28 +57,28 @@ testCanCallWithAuthorizedRole() (gas: 97807)
 testSetRoleCapabilities() (gas: 33337)
 testCanCallWithCustomAuthority() (gas: 98225)
 testSetPublicCapabilities() (gas: 31546)
-testSetDefaultTargetFloatPercent() (gas: 56001)
-testDefaultHarvestDelayOverridesCustomOfZero() (gas: 58714)
-testDefaultTargetFloatPercentOverridesCustomOfZero() (gas: 58104)
-testCustomHarvestDelayOverridesDefault() (gas: 78507)
-testSetCustomHarvestDelay() (gas: 55427)
-testCustomHarvestWindowOverridesDefault() (gas: 89136)
-testSetCustomFeePercent() (gas: 54807)
-testSetDefaultFeePercent() (gas: 55904)
-testSetCustomHarvestWindow() (gas: 86495)
-testCustomTargetFloatPercentOverridesDefault() (gas: 77946)
-testDefaultFeePercentOverridesCustomOfZero() (gas: 58039)
-testSetDefaultHarvestWindow() (gas: 67181)
-testDefaultHarvestWindowOverridesCustomOfZero() (gas: 69354)
-testSetCustomTargetFloatPercent() (gas: 54824)
-testSetDefaultHarvestDelay() (gas: 56617)
+testSetDefaultTargetFloatPercent() (gas: 55824)
+testDefaultHarvestDelayOverridesCustomOfZero() (gas: 58691)
+testDefaultTargetFloatPercentOverridesCustomOfZero() (gas: 57927)
+testCustomHarvestDelayOverridesDefault() (gas: 78484)
+testSetCustomHarvestDelay() (gas: 55404)
+testCustomHarvestWindowOverridesDefault() (gas: 89135)
+testSetCustomFeePercent() (gas: 54790)
+testSetDefaultFeePercent() (gas: 55887)
+testSetCustomHarvestWindow() (gas: 86494)
+testCustomTargetFloatPercentOverridesDefault() (gas: 77769)
+testDefaultFeePercentOverridesCustomOfZero() (gas: 58022)
+testSetDefaultHarvestWindow() (gas: 67180)
+testDefaultHarvestWindowOverridesCustomOfZero() (gas: 69353)
+testSetCustomTargetFloatPercent() (gas: 54647)
+testSetDefaultHarvestDelay() (gas: 56594)
 testIsVaultDeployed() (gas: 3690)
-testFailNoDuplicateVaults() (gas: 272747603292213)
-testDeployVault() (gas: 4141068)
-testVaultCreation() (gas: 4299523)
+testFailNoDuplicateVaults() (gas: 272747603292239)
+testDeployVault() (gas: 4141825)
+testVaultCreation() (gas: 4300041)
 testSetConfigurationModule() (gas: 3471)
 testFailDepositIntoNotWETHVault() (gas: 10656)
-testFailRedeemFromNotWETHVault() (gas: 244438)
-testAtomicDepositRedeemETH() (gas: 326125)
-testFailWithdrawFromNotWETHVault() (gas: 244338)
-testAtomicDepositWithdrawETH() (gas: 327660)
+testFailRedeemFromNotWETHVault() (gas: 244219)
+testAtomicDepositRedeemETH() (gas: 325860)
+testFailWithdrawFromNotWETHVault() (gas: 244119)
+testAtomicDepositWithdrawETH() (gas: 327415)