Gracefully removes mobile ucr version drop down from app advanced settings #35046
Conversation
ajeety4
added
product/feature-flag
| @@ -156,6 +156,9 @@ | |||
| values: | |||
| - ['2.0', '2.0'] | |||
| default: '2.0' | |||
| disabled: true | |||
| disabled_txt: Oops! This setting has been discontinued. We recommend you change this setting to Version 2, and it will no longer appear on your settings page. | |||
There was a problem hiding this comment.
Does this get translated at a later point when it gets shown in the UI? If not then it might be good to consider translating this text.
There was a problem hiding this comment.
Also, just a nitpick on the wording of the text. Perhaps it can be something like the following:
Oops! This setting has been discontinued. We recommend you change this setting to Version 2. Upon doing so this setting will no longer appear on this settings page.
The above might just make it a bit more clear as to when the setting will stop appearing on the page. No strong feelings however, and fine to leave as is if you feel the current text is clear enough.
There was a problem hiding this comment.
I love the idea that these be translated, but I think that might be a significantly heavier lift. I think it's okay to continue doing what the rest of this file does.
It is also worth noting that since you copied and pasted the exact text from line 111 that Danny wrote in 2014 (!), if that text is already translated, then this text will be translated too
There was a problem hiding this comment.
Yes, I did use the exact same text.
Just did a quick check and these messages in the yaml file are indeed translated.
| @@ -156,6 +156,9 @@ | |||
| values: | |||
| - ['2.0', '2.0'] | |||
| default: '2.0' | |||
| disabled: true | |||
| disabled_txt: Oops! This setting has been discontinued. We recommend you change this setting to Version 2, and it will no longer appear on your settings page. | |||
There was a problem hiding this comment.
I love the idea that these be translated, but I think that might be a significantly heavier lift. I think it's okay to continue doing what the rest of this file does.
It is also worth noting that since you copied and pasted the exact text from line 111 that Danny wrote in 2014 (!), if that text is already translated, then this text will be translated too
|
NOTE: Keeping this PR in draft only to avoid accidental merge since the related v2 migrations could take some amount of time to get done |
| default: '1.0' | ||
| default: '2.0' | ||
| disabled: true | ||
| disabled_txt: Oops! This setting has been discontinued. We recommend you change this setting to Version 2. Upon doing so this setting will no longer appear on this page. |
There was a problem hiding this comment.
nit: do we need "Oops"? Isn't that in case of errors?
There was a problem hiding this comment.
Good point. Addressed in bc58280 (merged with earlier commit)
ajeety4
force-pushed
the
ay/remove-mobile-ucr-dropdown
branch
from
1ec0180
to
bc58280
Compare
Product Description
This is only UI change where it gracefully removes mobile ucr version drop down from app advanced settings.
This uses an existing way to disable a setting and works as below
Demo:
UI.Remove.mobile.ucr.dropdown.mp4
Technical Summary
Ticket
Feature Flag
Mobile UCR Feature Flag
Safety Assurance
Safety story
Local testing done. Small UI change which is safe and non-breaking.
Automated test coverage
None
QA Plan
None
Rollback instructions
Labels & Review