Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS SQS support #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add AWS SQS support #113

wants to merge 2 commits into from

Conversation

sigHash
Copy link

@sigHash sigHash commented Oct 7, 2018

Enable NBXplorer to push notification to AWS SQS queue.

ENV NBXPLORER_BTCSTARTHEIGHT=""
ENV NBXPLORER_BTCRESCAN=""
ENV NBXPLORER_AWSSQSBLOCKQUEUEURL=""
ENV NBXPLORER_AWSSQSTRANSACTIONQUEUEURL=""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there or why it's empty?

volumes:
nbxplorer_datadir:


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file is useful. I should probably remove the regtest one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm new to docker. Feel free to comment more

@NicolasDorier
Copy link
Member

Need documentation in readme.

@sigHash
Copy link
Author

sigHash commented Oct 7, 2018

Need documentation in readme.

Working on it.

@Kukks
Copy link
Contributor

Kukks commented Oct 16, 2018

@sigHash and @NicolasDorier What do you think if we merge these into my other PR with Mass Transit so that we avoid even more breaking changes to the config?

@NicolasDorier
Copy link
Member

This PR is also breaking the indent everywhere making it impossible to review.

@sigHash
Copy link
Author

sigHash commented Oct 17, 2018

This PR is also breaking the indent everywhere making it impossible to review.

That's my fault, sorry. I'll fix it

@NicolasDorier
Copy link
Member

@sigHash might you give a try to @Kukks PR? I think it also support AWS among other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants