-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Poll Images from ECR Container Repository Plugin #3971
Conversation
@@ -803,7 +806,9 @@ func (impl CiCdPipelineOrchestratorImpl) CreateCiConf(createRequest *bean.CiConf | |||
|
|||
} else { | |||
//save pipeline in db end | |||
err = impl.AddPipelineMaterialInGitSensor(pipelineMaterials) | |||
if len(pipelineMaterials) != 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put more detailed comments
return artifacts, nil | ||
} | ||
|
||
func (impl CiArtifactRepositoryImpl) GetLatestArtifactTimeByCiPipelineId(ciPipelineId int) (*CiArtifact, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put comments
client/cron/CiTriggerCron.go
Outdated
if err != nil { | ||
return | ||
} | ||
//artifacts, err := impl.ciArtifactRepository.GetLatestArtifactTimeByCiPipelineIds(ciPipelineIds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unwanted comments
* added CODEOWNERS file * updated CODEOWNERS file * Update CODEOWNERS * Update CODEOWNERS --------- Co-authored-by: Shubham9t9 <[email protected]> Co-authored-by: Prakarsh <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Fixes #3978
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?