Introducing cronback services abstraction #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Configuration is broken up into `MainConfig` and now each service hosts its own config. - No more Role enum, roles are defined when services implement `CronbackService` trait. - Initialization of all services happen before we serve any traffic - Services are initialized by the order at which they are registered in main.rs - Cronback crate is also a library, this enables alternative main() functions from downstream crates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing cronback services abstraction
MainConfigand now each service hosts its own config.CronbackServicetrait.Stack created with Sapling. Best reviewed with ReviewStack.