Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split database files and migrations #16

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Split database files and migrations #16

merged 1 commit into from
Jul 25, 2023

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Jul 25, 2023

Split database files and migrations

This removes cronback-migration and moves migrations to each service, the approach is pretty dumb, in the follow up PRs, migrations and service bootstrapping will be consolidated in shared traits/types.


Stack created with Sapling. Best reviewed with ReviewStack.

MohamedBassem
MohamedBassem previously approved these changes Jul 25, 2023
cronback-lib/database/mod.rs Show resolved Hide resolved
cronback-services/src/scheduler/mod.rs Outdated Show resolved Hide resolved
@AhmedSoliman AhmedSoliman mentioned this pull request Jul 25, 2023
This removes cronback-migration and moves migrations to each service, the approach is pretty dumb, in the follow up PRs, migrations and service bootstrapping will be consolidated in shared traits/types.
@AhmedSoliman AhmedSoliman merged commit 0751032 into main Jul 25, 2023
3 checks passed
@AhmedSoliman AhmedSoliman deleted the pr16 branch July 25, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants