Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Misc compiler fixes and improvements -- part II #2138

Merged
merged 22 commits into from
Jun 7, 2023
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
ee57fb8
compiler: Fix Array.shape
FabioLuporini May 27, 2023
858c348
mpi: Support C-land Array halo exchange
FabioLuporini May 26, 2023
4a184e0
compiler: Relax WaitLock regions in a ScheduleTree
FabioLuporini May 29, 2023
2d1573c
compiler: Relax HaloTouch behavior upon uxreplace
FabioLuporini May 29, 2023
7d83331
compiler: Improve HaloTouch + uxreplace
FabioLuporini May 29, 2023
14257b1
mpi: Use ad-hoc Dimensions for buffers
FabioLuporini May 29, 2023
3cd5ae6
compiler: Patch merge_halospot in presence of Conditionals
FabioLuporini May 30, 2023
134dcd3
compiler: Enable rcompile customization
FabioLuporini May 30, 2023
864af11
mpi: Patch MPIMsg construction
FabioLuporini May 31, 2023
c683071
compiler: Patch double-buffering
FabioLuporini May 31, 2023
23a5824
compiler: Fix BoundSymbol and Indirection pickling
FabioLuporini Jun 1, 2023
ca81cea
compiler: Enable HierarchyLayer comparison
FabioLuporini Jun 1, 2023
e87a0c7
misc: Switch from pickle to cloudpickle
FabioLuporini Jun 1, 2023
b596dae
compiler: Patch HaloTouch via uxreplace
FabioLuporini Jun 1, 2023
a185119
compiler: Enhance Reconstructable with variadic args support
FabioLuporini Apr 19, 2023
04ae0ec
compiler: Revamp FIndexed for correct reconstruction
FabioLuporini Jun 1, 2023
0da295e
compiler: Patch c_char_p lowering
FabioLuporini Jun 4, 2023
dc43c52
compiler: Simplify is_on_device
FabioLuporini Jun 4, 2023
1a20fa8
compiler: Impose canonical ordering for HaloTouch args
FabioLuporini Jun 4, 2023
a38db4b
compiler: Promote distributor to AbstractFunction
FabioLuporini Jun 7, 2023
25fbc79
tests: Try both pickle and cloudpickle
FabioLuporini Jun 7, 2023
9636366
arch: Tidy up
FabioLuporini Jun 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
arch: Tidy up
  • Loading branch information
FabioLuporini committed Jun 7, 2023
commit 9636366fe7d98d4b06ecbf58c917537343f48211
12 changes: 7 additions & 5 deletions devito/arch/compiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,7 @@ def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)

platform = kwargs.pop('platform', configuration['platform'])

# Graviton flag
if platform is GRAVITON:
self.cflags += ['-mcpu=neoverse-n1']
Expand Down Expand Up @@ -493,13 +494,13 @@ class AOMPCompiler(Compiler):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)

language = kwargs.pop('language', configuration['language'])
platform = kwargs.pop('platform', configuration['platform'])

self.cflags += ['-Wno-unused-result', '-Wno-unused-variable']
if not configuration['safe-math']:
self.cflags.append('-ffast-math')

language = kwargs.pop('language', configuration['language'])
platform = kwargs.pop('platform', configuration['platform'])

if platform is NVIDIAX:
self.cflags.remove('-std=c99')
elif platform is AMDGPUX:
Expand Down Expand Up @@ -685,6 +686,7 @@ def __init__(self, *args, **kwargs):

platform = kwargs.pop('platform', configuration['platform'])
language = kwargs.pop('language', configuration['language'])

self.cflags.append("-xHost")

if configuration['safe-math']:
Expand Down Expand Up @@ -730,10 +732,10 @@ class IntelKNLCompiler(IntelCompiler):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)

self.cflags.append('-xMIC-AVX512')

language = kwargs.pop('language', configuration['language'])

self.cflags.append('-xMIC-AVX512')

if language != 'openmp':
warning("Running on Intel KNL without OpenMP is highly discouraged")

Expand Down