Fix transaction total calculation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eu não estava entendendo a lógica do microsserviço em Go do primeiro dia, principalmente porque sou dev Node, então eu tava revirando o código e adicionando testes pra conhecer mais os inputs e outputs do código.
O problema que eu encontrei é que o valor total da transaction estava pegando o valor total de shares em vez do valor de shares movimentado (
minShares)Se uma transaction era criada com 1.000.000 de shares, e
minShareera 5, o valor transacionado deveria ser de 5 shares * price, mas o código estava somando todas as 1.000.000 de shares nessa transaction.Eu achei que não fez sentido, por isso eu modifiquei o código, mas eu não entendo muito do domínio, nem de ações, nem de Go. Se esse for realmente o esperado, tudo certo. Apenas espero um feedback.
Valeu