build: lint-staged prettier before eslint #4445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prettier autofixes some issues eslint finds, letting prettier run first leads to less developer hassle for example, I've forgotten for weeks to change how my editor does tabs instead of spaces and I've been manually running `npm run fmt` to get around this. While yes I will also correct my editor, this feels like a positive change for all contributors
WilcoFiers
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prettier autofixes some issues eslint finds, letting prettier run first leads to less developer hassle
for example, I've forgotten for weeks to change how my editor does tabs instead of spaces and I've been manually running
npm run fmtto get around this. While yes I will also correct my editor, this feels like a positive change for all contributors<< Describe the changes >>
Closes: