chore: Update ACT test cases to run from W3C site #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
reviewed
Sep 6, 2022
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "id": "5c01ea", | |||
There was a problem hiding this comment.
Question: how do we want to name these files? We don't appear to have a naming convention for axe-core, and I'm not sure where the aria-props-allowed name comes from. Is that what it's called in ACT (but not listed in the rule itself)?
There was a problem hiding this comment.
I was sort of just winging it. ACT rules do have a file name. I could copy those I suppose. Here's the list of them: https://github.com/act-rules/act-rules.github.io/tree/develop/_rules
straker
previously requested changes
Sep 9, 2022
| const shouldRun = testcase.relativePath.match(/\.(xhtml|html?)$/); | ||
| (shouldRun ? it : xit)(testcase.testcaseTitle, async () => { | ||
| await driver.get(`${addr}/${testcase.relativePath}`); | ||
| const builder = new AxeBuilder(driver, axeSource); |
There was a problem hiding this comment.
Nice, I like this way of doing the tests
Co-authored-by: Steven Lambert <[email protected]>
straker
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #3499