Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix nightly build #3434

Merged
merged 5 commits into from
Apr 11, 2022
Merged

ci: fix nightly build #3434

merged 5 commits into from
Apr 11, 2022

Conversation

straker
Copy link
Contributor

@straker straker commented Apr 8, 2022

Apparently what was going on was that after npx browser-driver-manager install chromedriver installed chromedriver 99/100, doing npm install w3c/aria-practices#main would override the previously installed chromedriver with the version listed in package-lock.json. So the fix was to change the order of installs so that chromedriver was installed as the last thing.

Also fixed the nightly act running apg instead.

Here's the build showing nightly works now https://app.circleci.com/pipelines/github/dequelabs/axe-core/3537/workflows/1685f851-de20-40d5-b955-bf36ab194c51

@straker straker requested a review from a team as a code owner April 8, 2022 15:00
@straker straker merged commit 7e034be into develop Apr 11, 2022
@straker straker deleted the nightly-fix branch April 11, 2022 15:29
straker added a commit that referenced this pull request May 12, 2022
* ci: fix nightly build

* try again

* run

* fix it?

* revert workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants