Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i18n): update Japanese translation #3319

Merged
merged 8 commits into from
Mar 7, 2022

Conversation

ma10
Copy link
Contributor

@ma10 ma10 commented Dec 3, 2021

grunt translate --lang=ja based on the develop branch as of 2021-12-03
Add ja translation for checks/aria-errormessage/fail/hidden
Add ja translation for checks/aria-errormessage/incomplete/idrefs
add ja translation for checks/aria-level/{pass,fail}
Add ja translation for checks/aria-valid-attr-value/incomplete/idrefs
Add ja transation for checks/deprecatedrole/{pass,fail}
Add ja translation for checks/fallbackrole/incomplete
add ja translation for checks/p-as-heading/incomplete
Add ja translation for checks/color-contrast-enhanced/fail/*
Add ja translation for checks/color-contrast/fail/*

<< Describe the changes >>

Closes issue:

grunt translate --lang=ja based on the develop branch as of 2021-12-03
Add ja translation for checks/aria-errormessage/fail/hidden
Add ja translation for checks/aria-errormessage/incomplete/idrefs
add ja translation for checks/aria-level/{pass,fail}
Add ja translation for checks/aria-valid-attr-value/incomplete/idrefs
Add ja transation for checks/deprecatedrole/{pass,fail}
Add ja translation for checks/fallbackrole/incomplete
add ja translation for checks/p-as-heading/incomplete
Add ja translation for checks/color-contrast-enhanced/fail/*
Add ja translation for checks/color-contrast/fail/*
@ma10 ma10 requested a review from a team as a code owner December 3, 2021 04:19
@WilcoFiers WilcoFiers self-assigned this Dec 8, 2021
@WilcoFiers
Copy link
Contributor

Quick update on this. I'm looking for help on the review. You'll see it come up when it's there. Thank you once again for your contributions @ma10!

@WilcoFiers
Copy link
Contributor

Just to give a quick update on this. Not having much luck finding a reviewer. Still working on it though. We didn't forget.

Copy link
Contributor

@kiyochika kiyochika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ma10 @WilcoFiers Really sorry for taking a long time on the review. I have tried to adjust the details such as the usage of spaces, but still cannot take enough time for doing so. But now I have just reviewed on only nessesary and it should be good to go if the lines with my comments are fixed.

@@ -420,17 +420,23 @@
"pass": "サポートされているaria-errormessageの技術を使用しています",
"fail": {
"singular": "aria-errormessage の値 `${data.values}` はメッセージを通知する方法を使用しなければなりません (例えば、aria-live、aria-describedby、role=alert等)",
"plural": "aria-errormessage の値 `${data.values}` はメッセージを通知する方法を使用しなければなりません (例えば、aria-live、aria-describedby、role=alert等)"
"plural": "aria-errormessage の値 `${data.values}` はメッセージを通知する方法を使用しなければなりません (例えば、aria-live、aria-describedby、role=alert等)",
"hidden": "aria-errormessage の値 `${data.values}` は隠れている要素を参照することはできません"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「aria-errormessage」と「の」のあいだですが、こちら(fail)は空白ありで、次の「incomplete」では空白なしになっていました。。
おそらくは前回までに調整ができていなかったわけですが、このあたりは次回までに全体的にこちらでも見直しができればと思っているので、いったんそのままにしましょう。

locales/ja.json Outdated
@@ -478,7 +484,8 @@
},
"incomplete": {
"noId": "ARIA 属性の要素IDがページ上に存在しません: ${data.needsReview}",
"ariaCurrent": "ARIA 属性値が無効であるため、\"aria-current=true\" として扱われます: ${data.needsReview}"
"ariaCurrent": "ARIA 属性値が無効であるため、\"aria-current=true\" として扱われます: ${data.needsReview}",
"idrefs": "ARIA 属性で指定されている要素の ID がページ上に存在するかどうか判定できません: ${data.needsReview}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2行上の"noID"で”ARIA attribute element ID”を「ARIA 属性の要素ID」と訳してしまっているので、もしここで「ARIA 属性で指定されている要素の ID」とするのであれば、そちらもあわせる必要があると思います。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「ARIA 属性で指定されている要素の ID」は結構意訳だと思いますが、
「ARIA 属性の要素ID」は、個人的には非常に意図が分かりづらいと思ってこうしてみました。
どちらかに統一するのが望ましいと思いますが、どちらが適切でしょう?

ちなみに、noIdの方は、英単語の前後のスペースの有無がこの中で混在してますね。
ややこしいので個人的にはスペース無しで統一で良いような気がしています。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

はい、意図は認識しておりました。もともとの方針としては全体として翻訳用ファイルからは利用されている場所がわかりにくいこともあり直訳を基本としていたのですが、この部分についてはわかりやすくしてもよいと思いました。
ということで、「ARIA属性で指定されている要素のID」(スペースなし)でそれぞれ統一する、という方向でお願いできますでしょうか。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正しました。
CF: f645871 1f6b631

locales/ja.json Outdated Show resolved Hide resolved
locales/ja.json Outdated Show resolved Hide resolved
locales/ja.json Outdated Show resolved Hide resolved
locales/ja.json Outdated Show resolved Hide resolved
locales/ja.json Outdated
Comment on lines 648 to 649
"default": "Element has focusable descendants",
"notHidden": "Using a negative tabindex on an element inside an interactive control does not prevent assistive technologies from focusing the element (even with 'aria-hidden=true')"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"default": "Element has focusable descendants",
"notHidden": "Using a negative tabindex on an element inside an interactive control does not prevent assistive technologies from focusing the element (even with 'aria-hidden=true')"
"default": "要素の子孫にフォーカス可能なものがあります",
"notHidden": "インタラクティブなコントロールの内側の要素に負の tabindex を指定することで、('aria-hidden=true' とともに)支援技術がその要素にフォーカスできないようにしています"

翻訳漏れでしょうか。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳漏れでした。
defaultはsuggestいただいた通りで良いと思いますが、notHiddenはちょっと意図が違うように思います。 CF: 1577065

ma10 and others added 7 commits March 7, 2022 12:59
Copy link
Contributor

@kiyochika kiyochika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ma10 修正ありがとうございます。ちょっと寝ぼけていたようですね……記載いただいた内容で問題ないと思います。

Copy link
Contributor

@kiyochika kiyochika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ma10 ありがとうございます。修正確認しました。

@kiyochika
Copy link
Contributor

@WilcoFiers I believe the review is done (finally). Please check and merge the file if it's OK with you.
@ma10 Thank you for your work and patience.

@WilcoFiers
Copy link
Contributor

Fantastic! Much appreciated again @ma10, and @kiyochika thank you for reviewing.

Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the books; I have reviewed this PR for security.

@WilcoFiers WilcoFiers merged commit c2f4ebd into dequelabs:develop Mar 7, 2022
straker pushed a commit that referenced this pull request May 12, 2022
* chore(i18n): update Japanese translation

grunt translate --lang=ja based on the develop branch as of 2021-12-03
Add ja translation for checks/aria-errormessage/fail/hidden
Add ja translation for checks/aria-errormessage/incomplete/idrefs
add ja translation for checks/aria-level/{pass,fail}
Add ja translation for checks/aria-valid-attr-value/incomplete/idrefs
Add ja transation for checks/deprecatedrole/{pass,fail}
Add ja translation for checks/fallbackrole/incomplete
add ja translation for checks/p-as-heading/incomplete
Add ja translation for checks/color-contrast-enhanced/fail/*
Add ja translation for checks/color-contrast/fail/*

* Update locales/ja.json

role -> ロール

Co-authored-by: Kiyochika Nakamura <[email protected]>

* Update locales/ja.json

role -> ロール

Co-authored-by: Kiyochika Nakamura <[email protected]>

* Update locales/ja.json

陰 -> 影

Co-authored-by: Kiyochika Nakamura <[email protected]>

* Update locales/ja.json

陰 -> 影

Co-authored-by: Kiyochika Nakamura <[email protected]>

* Add ja translation for checks/no-focusable-content

* Make checks/aria-valid-attr-value/incomplete/noId consistent with ./idrefs

* Remove unnecessary whitespaces from checks/aria-valid-attr-value/incomplete/{noId,idrefs}

Co-authored-by: Kiyochika Nakamura <[email protected]>
ma10 added a commit to ma10/axe-core that referenced this pull request May 12, 2023
Remove whitespaces between English words and Japanese characters as agreed previously: dequelabs#3319

rules/accesskeys: wording change

rules/aria-focus-hidden: wording change

rules/aria-input-field-name/help: wording change

rules/aria-roledescription/help: wording change

rules/aria-text/description: make the location of the double-quotes consistent with the original text.

rules/aria-toggle-field-name/help: change wording

rules/aria-tooltip-name/description: wording change

rules/aria-treeitem-name/description: wording changes

rules/blink/help: correct translation

rules/color-contrast-enhanced: correct translation

rules/color-contrast: correct translation

rules/css-orientation-lock/help: wording change

rules/definition-list/help: correct translation

rules/duplicate-id-active: wording changes

rules/duplicate-id-aria/description: wording change

rules/focus-order-semantics: correct translation

rules/form-field-multiple-labels/help: wording change

rules/frame-focusable-content: correct translation

rules/frame-tested/help: change wording

rules/frame-title: correct translation

rules/hidden-content* correct translation

rules/identical-links-same-purpose: correct translation

rules/label-title-only/description: correct translation

rules/landmark-complementary-is-top-level/help: wording change

rules/landmark-one-main/description: correct translation

rules/landmark-unique/description: correct translation.

rules/link-in-text-block: correct translation

rules/meta-refresh-no-exceptions: correct translation

rules/meta-refresh: correct translation

rules/meta-viewport-large/help: correct translation

rules/meta-viewport: correct translation

rules/nested-interactive: correct translation

rules/no-autoplay-audio/help: correct translation

rules/p-as-heading: correct translation

rules/presentation-role-conflict: correct translation

rules/role-img-alt: correct translation

rules/scrollable-region-focusable: correct translation

rules/svg-img-alt/help: correct translation

rules/tabindex/help: correct translation

rules/table-duplicate-name: correct translation

rules/table-fake-caption/help: correct translation

rules/target-size/help: correct translation

rules/td-has-header: correct translation

rules/td-headers-attr: correct translation

rules/th-has-data-cells: swap the content of help and description to be consistent with the original.

checks/aria-allowed-attr/incomplete: correct translation

checks/aria-allowed-role/{fail,incomplete: correct translation

checks/aria-busy/fail: correct translation

checks/aria-errormessage{pass,fail}: correct translation

checks/aria-required-children/fail/unallowed: sync with the en version

checks/aria-allowed-attr/incomplete: correct translation

checks/deprecatedrole/pass: correct translation

checks/has-global-aria-attribute: correct translation

checks/color-contrast-enhanced/incomplete/pseudoContent: consistent wording with other phrases

checks/color-contrast/incomplete/pseudoContent: consistent wording with other phrases

checks/pseudoContent/pass: consistent wording with other phrases

checks/link-in-text-block/incomplete/{default,bgColorContrast}: correct translation

checks/accesskeys: correct translation

checks/focusable-disabled: correct translation

checks/focusable-modal-open: correct translation

checks/focusable-not-tabbable: correct translation

checks/landmark-is-top-level/fail: correct translation

checks/page-has-main/pass: correct translation

checks/alt-space-value/fail: correct translation

checks/explicit-label: correct translation

checks/help-same-as-label: correct translation

checks/hidden-explicit-label: correct translation

checks/multiple-label/fail: correct translation

checks/landmark-is-unique/pass: correct translation

checks/listitem/fail/roleNotValid: correct translation

checks/only-dlitems: correct translation

checks/only-listitems: correct translation

checks/caption/incomplete: correct translation

checks/no-autoplay-audio: correct translation

checks/css-orientation-lock: correct translation

checks/target-offset: correct translation

checks/target-size: correct translation

checks/header-present: correct translation

checks/identical-links-same-purpose/incomplete: correct translation

checks/identical-links-same-purpose: correct translation

Make the translation of the oword "present" consistent throughout the file.

checks/meta-refresh-no-exceptions/fail: correct translation

checks/meta-refresh/fail: correct translation

checks/p-as-heading/fail: correct translation

checks/duplicate-id-aria: correct translation

checks/duplicate-id: correct translation

checks/button-has-visible-text/{pass,fail}: correct translation

checks/has-alt: correct translation

checks/important-letter-spacing: correct translation

checks/important-line-height: correct translation

checks/important-word-spacing: correct translation

checks/non-empty-alt/pass: correct translation

checks/non-empty-if-present: correct translation

checks/non-empty-placeholder: correct translation

checks/non-empty-title: correct translation

checks/non-empty-value: correct translation

checks/presentational-role: correct translation

checks/svg-non-empty-title: correct translation

checks/caption-faked/pass: typo fix

failureSummary/incompleteFallbackMessage: correct translation

Make the translation for "role attribute" consistent throughout the file.

Add ja translation for checks/aria-conditional-attr
WilcoFiers added a commit that referenced this pull request Aug 29, 2023
* Chore(i18n): Update and correct Japanese translation

Remove whitespaces between English words and Japanese characters as agreed previously: #3319

rules/accesskeys: wording change

rules/aria-focus-hidden: wording change

rules/aria-input-field-name/help: wording change

rules/aria-roledescription/help: wording change

rules/aria-text/description: make the location of the double-quotes consistent with the original text.

rules/aria-toggle-field-name/help: change wording

rules/aria-tooltip-name/description: wording change

rules/aria-treeitem-name/description: wording changes

rules/blink/help: correct translation

rules/color-contrast-enhanced: correct translation

rules/color-contrast: correct translation

rules/css-orientation-lock/help: wording change

rules/definition-list/help: correct translation

rules/duplicate-id-active: wording changes

rules/duplicate-id-aria/description: wording change

rules/focus-order-semantics: correct translation

rules/form-field-multiple-labels/help: wording change

rules/frame-focusable-content: correct translation

rules/frame-tested/help: change wording

rules/frame-title: correct translation

rules/hidden-content* correct translation

rules/identical-links-same-purpose: correct translation

rules/label-title-only/description: correct translation

rules/landmark-complementary-is-top-level/help: wording change

rules/landmark-one-main/description: correct translation

rules/landmark-unique/description: correct translation.

rules/link-in-text-block: correct translation

rules/meta-refresh-no-exceptions: correct translation

rules/meta-refresh: correct translation

rules/meta-viewport-large/help: correct translation

rules/meta-viewport: correct translation

rules/nested-interactive: correct translation

rules/no-autoplay-audio/help: correct translation

rules/p-as-heading: correct translation

rules/presentation-role-conflict: correct translation

rules/role-img-alt: correct translation

rules/scrollable-region-focusable: correct translation

rules/svg-img-alt/help: correct translation

rules/tabindex/help: correct translation

rules/table-duplicate-name: correct translation

rules/table-fake-caption/help: correct translation

rules/target-size/help: correct translation

rules/td-has-header: correct translation

rules/td-headers-attr: correct translation

rules/th-has-data-cells: swap the content of help and description to be consistent with the original.

checks/aria-allowed-attr/incomplete: correct translation

checks/aria-allowed-role/{fail,incomplete: correct translation

checks/aria-busy/fail: correct translation

checks/aria-errormessage{pass,fail}: correct translation

checks/aria-required-children/fail/unallowed: sync with the en version

checks/aria-allowed-attr/incomplete: correct translation

checks/deprecatedrole/pass: correct translation

checks/has-global-aria-attribute: correct translation

checks/color-contrast-enhanced/incomplete/pseudoContent: consistent wording with other phrases

checks/color-contrast/incomplete/pseudoContent: consistent wording with other phrases

checks/pseudoContent/pass: consistent wording with other phrases

checks/link-in-text-block/incomplete/{default,bgColorContrast}: correct translation

checks/accesskeys: correct translation

checks/focusable-disabled: correct translation

checks/focusable-modal-open: correct translation

checks/focusable-not-tabbable: correct translation

checks/landmark-is-top-level/fail: correct translation

checks/page-has-main/pass: correct translation

checks/alt-space-value/fail: correct translation

checks/explicit-label: correct translation

checks/help-same-as-label: correct translation

checks/hidden-explicit-label: correct translation

checks/multiple-label/fail: correct translation

checks/landmark-is-unique/pass: correct translation

checks/listitem/fail/roleNotValid: correct translation

checks/only-dlitems: correct translation

checks/only-listitems: correct translation

checks/caption/incomplete: correct translation

checks/no-autoplay-audio: correct translation

checks/css-orientation-lock: correct translation

checks/target-offset: correct translation

checks/target-size: correct translation

checks/header-present: correct translation

checks/identical-links-same-purpose/incomplete: correct translation

checks/identical-links-same-purpose: correct translation

Make the translation of the oword "present" consistent throughout the file.

checks/meta-refresh-no-exceptions/fail: correct translation

checks/meta-refresh/fail: correct translation

checks/p-as-heading/fail: correct translation

checks/duplicate-id-aria: correct translation

checks/duplicate-id: correct translation

checks/button-has-visible-text/{pass,fail}: correct translation

checks/has-alt: correct translation

checks/important-letter-spacing: correct translation

checks/important-line-height: correct translation

checks/important-word-spacing: correct translation

checks/non-empty-alt/pass: correct translation

checks/non-empty-if-present: correct translation

checks/non-empty-placeholder: correct translation

checks/non-empty-title: correct translation

checks/non-empty-value: correct translation

checks/presentational-role: correct translation

checks/svg-non-empty-title: correct translation

checks/caption-faked/pass: typo fix

failureSummary/incompleteFallbackMessage: correct translation

Make the translation for "role attribute" consistent throughout the file.

Add ja translation for checks/aria-conditional-attr

* Add translation for checks/link-in-text-block-style/incomplete

* Add ja translation for rules/aria-deprecated-role

* Add ja translation for checks/color-contrast/incomplete/complexTextShadows

* Update locales/ja.json

Co-authored-by: Wilco Fiers <[email protected]>

* checks/aria-allowed-role/imcomplete: make the wording consistent between singular and plural

* Add translation for rules/aria-prohibited-attr

* Add translations for rules/aria-braille-equivalent, rules/aria-conditional-attr, checks/braille-label-equivalent, and checks/braille-roledescription-equivalent

* Update locales/ja.json

Co-authored-by: Wilco Fiers <[email protected]>

* Update checks/braille-roledescription-equivalent/pass to make it inline with the changes introduced by PR #4133

* Correct the error in the previous commit.

---------

Co-authored-by: Masafumi Max NAKANE <[email protected]>
Co-authored-by: Wilco Fiers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants