Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(region): contents in iframes should pass the region rule if the iframe itself is in a region #2949

Merged
merged 17 commits into from
Jun 23, 2021
Merged

fix(region): contents in iframes should pass the region rule if the iframe itself is in a region #2949

merged 17 commits into from
Jun 23, 2021

Commits on May 19, 2021

  1. only run region rule on initiatior; iframe results will be on their o… 

    …wn reports
    @clottman
    clottman committed May 19, 2021
    Configuration menu
    Copy the full SHA
    1699d8d View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. add test

    @clottman
    clottman committed May 24, 2021
    Configuration menu
    Copy the full SHA
    080d4d2 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. content in iframes that are in regions should be counted as within th… 

    …e region
    @clottman
    clottman committed May 26, 2021
    Configuration menu
    Copy the full SHA
    30d5646 View commit details
    Browse the repository at this point in the history

  2. add another nested iframe test

    @clottman
    clottman committed May 26, 2021
    Configuration menu
    Copy the full SHA
    84ce856 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Merge branch 'develop' into 2690-ignore-iframe-content-for-region

    @clottman
    clottman committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    bccc887 View commit details
    Browse the repository at this point in the history

  2. move match ancestry function to shared file

    @clottman
    clottman committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    f702e10 View commit details
    Browse the repository at this point in the history

  3. attempt to move things forward

    @clottman
    clottman committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    fe1d909 View commit details
    Browse the repository at this point in the history

  4. working now

    @clottman
    clottman committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    9f3a87a View commit details
    Browse the repository at this point in the history

  5. remove test that won't work because that logic is in the after method… 

    … now
    @clottman
    clottman committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    738a261 View commit details
    Browse the repository at this point in the history

  6. add unit tests for after method

    @clottman
    clottman committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    6d4f7fa View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. test only result

    @clottman
    clottman committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    16d3962 View commit details
    Browse the repository at this point in the history

  2. match ancestry tests

    @clottman
    clottman committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    89ee902 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. passes

    @clottman
    clottman committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    98471d1 View commit details
    Browse the repository at this point in the history

  2. add comment

    @clottman
    clottman committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    8853b86 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. refactor

    @clottman
    clottman committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    123ab09 View commit details
    Browse the repository at this point in the history

  2. more refactor

    @clottman
    clottman committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    7816093 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. add additional test

    @clottman
    clottman committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    ed6b2f1 View commit details
    Browse the repository at this point in the history