Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(skip-link): work with absolute and relative paths #2875

Merged
merged 15 commits into from
Jan 20, 2022
Merged

fix(skip-link): work with absolute and relative paths #2875

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b40a3f5
fix(skip-link): work with absoulte and relative paths
straker Apr 15, 2021
1b31b8a
revert playground
straker Apr 15, 2021
dcb5582
fix ie11
straker Apr 15, 2021
b29fb61
fix ie11 again
straker Apr 15, 2021
44adf1e
Update lib/commons/dom/is-skip-link.js
straker Apr 19, 2021
76d0504
Merge branch 'develop' into absolute-skip-link
straker Jan 10, 2022
8cea183
Merge branch 'absolute-skip-link' of https://github.com/dequelabs/axe…
straker Jan 17, 2022
46d87ef
finalize
straker Jan 17, 2022
beda3e1
fix
straker Jan 17, 2022
f11f07a
fix ie11 (always)
straker Jan 17, 2022
35aa471
typo
straker Jan 17, 2022
da2874a
fix jsdom test
straker Jan 18, 2022
11296ca
Update lib/commons/dom/is-current-page-link.js
straker Jan 19, 2022
6e66a3b
fix issue with usemap
straker Jan 19, 2022
ac30d4e
fix ie11
straker Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/commons/dom/is-skip-link.js 
Co-authored-by: Wilco Fiers <[email protected]>
  • Loading branch information
@straker @WilcoFiers
straker and WilcoFiers committed Apr 19, 2021
commit 44adf1e26af22854301f8fb8a648c6e32f8cddc2
2 changes: 1 addition & 1 deletion lib/commons/dom/is-skip-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function isSkipLink(element) {
const currentPage = window.location.origin + window.location.pathname;
straker marked this conversation as resolved.
Show resolved Hide resolved
firstPageLink = querySelectorAll(
axe._tree,
'a[href]:not([href^="javascript"])'
'a[href]:not([href^="javascript:"])'
).find(({ actualNode }) => {
const href = actualNode.getAttribute('href');
if (angularSkipLinkRegex.test(href)) {
Expand Down