Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(virtual-node): add attrNames property which returns list of attribute names #2741

Merged
merged 4 commits into from
Jan 11, 2021
Merged

feat(virtual-node): add attrNames property which returns list of attribute names #2741

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e43e6d
feat(virtual-node): add attrNames property which returns list of attr…
straker Jan 7, 2021
5b4aa70
comments
straker Jan 7, 2021
4d1827f
fix
straker Jan 7, 2021
c49ac81
Update test/core/base/virtual-node/abstract-virtual-node.js
straker Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/core/base/virtual-node/abstract-virtual-node.js 
Co-authored-by: Stephen Mathieson <[email protected]>
  • Loading branch information
@straker @stephenmathieson
straker and stephenmathieson committed Jan 8, 2021
commit c49ac81609d45dea056731a223620d390d2f0efe
6 changes: 2 additions & 4 deletions test/core/base/virtual-node/abstract-virtual-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,10 @@ describe('AbstractVirtualNode', function() {
it('should throw an error when accessing attrNames', function() {
function fn() {
var abstractNode = new axe.AbstractVirtualNode();
if (abstractNode.attrNames.length) {
return;
}
return abstractNode.attrNames;
}

assert.throws(fn);
assert.throws(fn, 'VirtualNode class must have an "attrNames" property');
});

it('should throw an error when accessing hasClass', function() {
Expand Down