Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): missing translations for DE #2704

Merged
merged 5 commits into from
Jan 12, 2021

Conversation

Zauberbutter
Copy link
Contributor

Maybe requires proofreading here & there.

@Zauberbutter Zauberbutter requested a review from a team as a code owner December 21, 2020 17:15
@CLAassistant
Copy link

CLAassistant commented Dec 21, 2020

CLA assistant check
All committers have signed the CLA.

@Zauberbutter Zauberbutter changed the title Adds missing translations for DE feat(locale): missing translations for DE Dec 21, 2020
@straker
Copy link
Contributor

straker commented Dec 22, 2020

Thanks for the updated translations. We're looking for someone internally who can speak German to verify the additions. It might take awhile with the Christmas holiday coming up but we'll get it merged.

locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
dylanb
dylanb previously requested changes Dec 22, 2020
Copy link
Contributor

@dylanb dylanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please se the comments for changes and discussions

@Zauberbutter
Copy link
Contributor Author

Today I compared the already translated entries with a freshly generated file and saw that many description entries are set to "" although they aren't in the english file. Does this mean that they'll be treated as not set?

@dylanb
Copy link
Contributor

dylanb commented Dec 22, 2020

Good question that @WilcoFiers or @straker can probably answer better than I can

@straker
Copy link
Contributor

straker commented Dec 22, 2020

@Cerberooo Correct. An empty string will be treated as a non-existent translation and axe will fill in the translation with the English version. Preferably we'd like all the translation strings to be filled in.

@Zauberbutter
Copy link
Contributor Author

@dylanb If you like you can take a look at the newly added strings.

locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
locales/de.json Outdated Show resolved Hide resolved
Copy link
Contributor

@dylanb dylanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spelling mistake and the usage of Zugänglichkeit-Objekt des Elements should be reversed

@Zauberbutter
Copy link
Contributor Author

@straker I think it's ready to go!

@straker
Copy link
Contributor

straker commented Jan 12, 2021

Reviewed for security.

Thanks so much for putting this together!

@straker straker merged commit f312994 into dequelabs:develop Jan 12, 2021
@Zauberbutter Zauberbutter deleted the localization-de branch January 13, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants