tests: run ChromeHeadless for integration test #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright. So after trying every combination of things suggested by the interwebs to fix this, the only thing that finally has worked consistently is to use chrome headless. I have stopped and restarted the job about 6 or 7 times now and it has yet to fail to start. I don't understand it but here we are. |
WilcoFiers
previously requested changes
Dec 2, 2020
| @@ -4,7 +4,6 @@ var globby = require('globby'); | |||
| var WebDriver = require('selenium-webdriver'); | |||
| var chrome = require('selenium-webdriver/chrome'); | |||
| var chromedriver = require('chromedriver'); | |||
| var isCI = require('is-ci'); | |||
There was a problem hiding this comment.
Looks like we can then drop this dependency.
WilcoFiers
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome is failing to start a lot and with no apparent reason as this was all working fine when running it as Grunt. This is a copied/pasted file that worked before but now fails. Trying this to see if it resolves the issues as suggested in various sites.
Going to cancel and rerun this build a couple of times to see if it's working consistently.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)