refactor(core/utils): Convert to ES modules #2159
Conversation
|
I had to comment out most of the tests in |
straker
changed the title
| @@ -1,10 +0,0 @@ | |||
| describe('utils', function() { | |||
There was a problem hiding this comment.
Very glad to see this going away.
| var comingOut = axe.utils.finalizeRuleResult(goingIn); | ||
|
|
||
| assert.equal(goingIn, comingOut); | ||
| }); | ||
|
|
||
| it('passes the nodes property to utils.aggregateNodeResults', function() { |
There was a problem hiding this comment.
Agreed these are bad tests, but I'd feel much better if we replaced it instead of just taking it out.
| }); | ||
|
|
||
| describe('given command rules', function() { | ||
| describe.skip('given command rules', function() { |
There was a problem hiding this comment.
I don't think we should disable / skip the tests that are in here. Let's fix them.
| @@ -107,7 +107,7 @@ describe('axe.utils.preload integration test', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('returns NO preloaded CSSOM assets when requested stylesheet does not exist`', function(done) { | |||
| it.skip('returns NO preloaded CSSOM assets when requested stylesheet does not exist`', function(done) { | |||
There was a problem hiding this comment.
Either remove the test of fix them. If we leave them in this state we might never going to turn them back on.
| }); | ||
| }); | ||
|
|
||
| describe.skip('frame-wait-time option', function() { |
There was a problem hiding this comment.
Fix them or take them out.
|
Alternative to turning these test back on, let me know how we're going to make sure they will get turned back on before the next release. |
|
Issue for resolving the tests at a later time before a release #2168 |
* develop: refactor(core/utils): Convert to ES modules (#2159)
Ref #2120
Reviewer checks
Required fields, to be filled out by PR reviewer(s)